third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2704123003: Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout (Closed)

Patch Set: 2017-02-21T12:50:46 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index ddfaa7f661a719a4606d3f71c834bde6d8e92fee..a3c95cdf0c2a015236407345b787b531070f5f86 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -78,7 +78,8 @@ TEST_F(FrameSelectionTest, PaintCaretShouldNotLayout) {

selection().setSelection(

SelectionInDOMTree::Builder().collapse(Position(text, 0)).build());

document().view()->updateAllLifecyclePhases();

- EXPECT_TRUE(selection().isCaret());

+ EXPECT_TRUE(

+ selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret());

EXPECT_TRUE(toLayoutBlock(document().body()->layoutObject())

->shouldPaintCursorCaret());