Expand FrameSeleciton::isCaret() to increase chances of hoisting update layout

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 60 matching lines @@
   document().view()->updateAllLifecyclePhases();
 
   document().body()->setContentEditable("true", ASSERT_NO_EXCEPTION);
   document().body()->focus();
   EXPECT_TRUE(document().body()->isFocused());
 
   selection().setCaretVisible(true);
   selection().setSelection(
       SelectionInDOMTree::Builder().collapse(Position(text, 0)).build());
   document().view()->updateAllLifecyclePhases();
-  EXPECT_TRUE(selection().isCaret());
+  EXPECT_TRUE(
+      selection().computeVisibleSelectionInDOMTreeDeprecated().isCaret());
   EXPECT_TRUE(toLayoutBlock(document().body()->layoutObject())
                   ->shouldPaintCursorCaret());
 
   int startCount = layoutCount();
   {
     // To force layout in next updateLayout calling, widen view.
     FrameView& frameView = dummyPageHolder().frameView();
     IntRect frameRect = frameView.frameRect();
     frameRect.setWidth(frameRect.width() + 1);
     frameRect.setHeight(frameRect.height() + 1);
@@ skipping 179 matching lines @@
   EXPECT_EQ(selection().start(), caretPosition().position());
   document().updateStyleAndLayout();
   selection().updateIfNeeded();
 
   EXPECT_EQ(Position(), selection().start())
       << "selection().updateIfNeeded() does nothing.";
   EXPECT_EQ(selection().start(), caretPosition().position());
 }
 
 }  // namespace blink