Support animating <percentage> and <length-percentage> custom properties

Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions on registered custom properties
are pending implementation.

BUG=671904
Review-Url: https://codereview.chromium.org/2701533005
Cr-Commit-Position: refs/heads/master@{#451558}
Committed: https://chromium.googlesource.com/chromium/src/+/bf1d7a3c3dc23860270f9cf267e4722b963500ab

[alancutter (OOO until 2018), 2017-02-17 04:44:37]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-02-17 04:59:59]

Again, please mention in the CL description why it adds test expectations that
contain failures.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-interpolation.html:9:
font-size: 20px;
Add a comment to indicate the purpose of this line. Or move it to its own test.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:25:
'percentage is treated as neutral value');
Please elaborate this to document the particular condition that causes it to be
treated as neutral. Perhaps also mention that it triggers the console warning in
the expected output.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp:216:
if (value == 0 &&
Although this is a tiny bug fix, I'd prefer to see it in its own patch with a
dedicated test.

[suzyh_UTC10 (ex-contributor), 2017-02-17 05:00:32]

Oh, also, is there a reason that these two property types need to be in a single
patch?

[alancutter (OOO until 2018), 2017-02-19 23:32:26]

Description was changed from

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0%.

BUG=671904
==========

to

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions don't yet apply to registered
custom properties.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-02-19 23:38:58]

On 2017/02/17 at 05:00:32, suzyh wrote:
> Oh, also, is there a reason that these two property types need to be in a
single patch?

The
animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html
makes more sense when you can see that the implementation is using the same
CSSInterpolationType for multiple custom property syntaxes. It verifies that it
doesn't support more than it's supposed to.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-interpolation.html:9:
font-size: 20px;
On 2017/02/17 at 04:59:58, suzyh wrote:
> Add a comment to indicate the purpose of this line. Or move it to its own
test.

Done.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:25:
'percentage is treated as neutral value');
On 2017/02/17 at 04:59:58, suzyh wrote:
> Please elaborate this to document the particular condition that causes it to
be treated as neutral. Perhaps also mention that it triggers the console warning
in the expected output.

Done.

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
(right):

https://codereview.chromium.org/2701533005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp:216:
if (value == 0 &&
On 2017/02/17 at 04:59:59, suzyh wrote:
> Although this is a tiny bug fix, I'd prefer to see it in its own patch with a
dedicated test.

This bug is unreachable without this change.

[alancutter (OOO until 2018), 2017-02-19 23:42:02]

Description was changed from

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions don't yet apply to registered
custom properties.

BUG=671904
==========

to

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions on registered custom properties
are pending implementation.

BUG=671904
==========

[suzyh_UTC10 (ex-contributor), 2017-02-20 00:22:01]

lgtm once test documentation strings fixed.

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:7:
// The console warnings about "Invalid keyframe value" are expected for this
test.
Heads-up that this would be affected by
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs
(ignoring console warnings) if it comes to pass.

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:38:
'percentage is treated as neutral value');
Copy-paste error from (previous version of) test above? Remember to also
elaborate this comment as for the previous test.

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:41:
'--length is being animated');
Copy-paste error from test above?

[alancutter (OOO until 2018), 2017-02-20 00:27:09]

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html
(right):

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:7:
// The console warnings about "Invalid keyframe value" are expected for this
test.
On 2017/02/20 at 00:22:01, suzyh wrote:
> Heads-up that this would be affected by
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3Ob2lq14KEs
(ignoring console warnings) if it comes to pass.

Saw that one, looks like it's only for WPT.

https://codereview.chromium.org/2701533005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/custom-properties/length-percentage-type-mismatch-no-interpolation.html:41:
'--length is being animated');
On 2017/02/20 at 00:22:01, suzyh wrote:
> Copy-paste error from test above?

Copy paste errors are source of all that is bad.

[alancutter (OOO until 2018), 2017-02-20 00:33:44]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 00:33:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 01:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 01:37:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2017-02-20 03:35:52]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-20 03:35:52]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2701533005/#ps60001
(title: "update expectations")

[commit-bot: I haz the power, 2017-02-20 03:36:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 05:10:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487561752011900,
"parent_rev": "7994ae1b005e8f02c1bd554e5006e0546e59c3e7", "commit_rev":
"bf1d7a3c3dc23860270f9cf267e4722b963500ab"}

[commit-bot: I haz the power, 2017-02-20 05:12:01]

Description was changed from

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions on registered custom properties
are pending implementation.

BUG=671904
==========

to

==========
Support animating <percentage> and <length-percentage> custom properties

This patch adds support for animating custom properties registered with
the <percentage> or <length-percentage> syntax.
It also fixes a bug in LengthInterpolationFunctions::createCSSValue()
when applying 0% that's unreachable without this patch.

The transition tests fail as transitions on registered custom properties
are pending implementation.

BUG=671904

Review-Url: https://codereview.chromium.org/2701533005
Cr-Commit-Position: refs/heads/master@{#451558}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf1d7a3c3dc23860270f9cf267e4...
==========

[commit-bot: I haz the power, 2017-02-20 05:12:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf1d7a3c3dc23860270f9cf267e4...