Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2703593004: Support animating <number> custom properties (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support animating <number> custom properties This patch adds support for animating custom properties registered with the <number> syntax. The transition tests fail as transitions on registered custom properties are pending implementation. BUG=671904 Review-Url: https://codereview.chromium.org/2703593004 Cr-Commit-Position: refs/heads/master@{#451538} Committed: https://chromium.googlesource.com/chromium/src/+/ff93bd9b7a7f41ac9ec1d1844e7cdce8eceba6bf

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-17 03:32:09 UTC) #2
suzyh_UTC10 (ex-contributor)
Please explain in the CL description why the expected test output contains failures. (I assume ...
3 years, 10 months ago (2017-02-17 04:43:32 UTC) #3
alancutter (OOO until 2018)
On 2017/02/17 at 04:43:32, suzyh wrote: > Please explain in the CL description why the ...
3 years, 10 months ago (2017-02-19 23:43:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2703593004/1
3 years, 10 months ago (2017-02-19 23:45:12 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 01:08:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff93bd9b7a7f41ac9ec1d1844e7c...

Powered by Google App Engine
This is Rietveld 408576698