third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp - Issue 2701533005: Support animating <percentage> and <length-percentage> custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp

Issue 2701533005: Support animating <percentage> and <length-percentage> custom properties (Closed)

Patch Set: update expectations Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/custom-properties/percentage-type-interpolation-expected.txt ('k') | third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp b/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp

index 57cd28bad1dd5a99b47189030b03c7fa2159a135..06b707d8353fb22edf79a9fa10b5c40d75d7db2d 100644

--- a/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp

@@ -343,13 +343,13 @@ CSSInterpolationTypesMap::createCSSInterpolationTypesForSyntax(

result.push_back(WTF::makeUnique<CSSColorInterpolationType>(property));

break;

case CSSSyntaxType::Length:

+ case CSSSyntaxType::LengthPercentage:

+ case CSSSyntaxType::Percentage:

result.push_back(WTF::makeUnique<CSSLengthInterpolationType>(property));

break;

case CSSSyntaxType::Number:

result.push_back(WTF::makeUnique<CSSNumberInterpolationType>(property));

break;

- case CSSSyntaxType::Percentage:

- case CSSSyntaxType::LengthPercentage:

case CSSSyntaxType::Image:

case CSSSyntaxType::Url:

case CSSSyntaxType::Integer: