Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp

Issue 2701533005: Support animating <percentage> and <length-percentage> custom properties (Closed)
Patch Set: update expectations Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
diff --git a/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
index 1553826ba2d5f5a7a0f53dbfc341d5d5ba94a064..2dbbb20a5004dd8ff44ac4ffb5a80038411f7a85 100644
--- a/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
+++ b/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
@@ -213,8 +213,8 @@ const CSSValue* LengthInterpolationFunctions::createCSSValue(
for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; i++) {
double value = toInterpolableNumber(*interpolableList.get(i)).value();
- if (value == 0 ||
- (i == CSSPrimitiveValue::UnitTypePercentage && !hasPercentage)) {
+ if (value == 0 &&
+ (i != CSSPrimitiveValue::UnitTypePercentage || !hasPercentage)) {
continue;
}
CSSPrimitiveValue* currentValue =
« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698