Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2701083002:
Preserve handles visibility when modifying selection (Closed)
|
Created:
3 years, 10 months ago by Tima Vaisburd Modified:
3 years, 9 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPreserve handles visibility when modifying selection
When modifying selection programmatically by the method
FrameSelection::setSelectedRange preserve selection handles visibility.
BUG=685420
Review-Url: https://codereview.chromium.org/2701083002
Cr-Commit-Position: refs/heads/master@{#457341}
Committed: https://chromium.googlesource.com/chromium/src/+/4e61755b3dd5d278d51896e56e4f9aa51beff6a2
Patch Set 1 #Patch Set 2 : Added unit test #
Total comments: 4
Patch Set 3 : Removed redundant EXPECTs in test #
Messages
Total messages: 33 (23 generated)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
timav@chromium.org changed reviewers: + amaralp@chromium.org
PTAL.
timav@chromium.org changed reviewers: + sgurun@chromium.org
+sgurun@: FYI
amaralp@chromium.org changed reviewers: + yosin@chromium.org
On 2017/02/17 at 23:35:42, timav wrote: > PTAL. Added yosin@ for OWNERS. I can't think of any situation where the touch handles are visible and |FrameSelection::setSelectedRange()| should not show handles. Maybe there could be a situation with the IME? yosin@ what do you think?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/02/18 at 01:02:30, amaralp wrote: > On 2017/02/17 at 23:35:42, timav wrote: > > PTAL. > > Added yosin@ for OWNERS. > > I can't think of any situation where the touch handles are visible and |FrameSelection::setSelectedRange()| should not show handles. > Maybe there could be a situation with the IME? yosin@ what do you think? Could you add a test case for this patch to avoid regression in the future[1]? Thanks in advance. [1] https://goo.gl/OpRI6x Importance and requirements of testing in Chromium
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by timav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Sorry it took so long to react. I added a test which is similar to existing SelectAllPreservesHandle. Please take another look.
On 2017/03/14 21:47:39, Tima Vaisburd wrote: > Sorry it took so long to react. I added a test which is similar to existing > SelectAllPreservesHandle. Please take another look. A gentle ping.
lgtm w/ nits https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right): https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:304: EXPECT_FALSE(selection().isHandleVisible()); nit: Since other test covers this, we don't need to check it here. Please remove this. https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:320: EXPECT_TRUE(selection().isHandleVisible()); nit: Since other test covers this, we don't need to check it here. Please remove this.
https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right): https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:304: EXPECT_FALSE(selection().isHandleVisible()); On 2017/03/16 01:10:26, yosin_UTC9 wrote: > nit: Since other test covers this, we don't need to check it here. Please remove > this. Done. https://codereview.chromium.org/2701083002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:320: EXPECT_TRUE(selection().isHandleVisible()); On 2017/03/16 01:10:26, yosin_UTC9 wrote: > nit: Since other test covers this, we don't need to check it here. Please remove > this. Done.
The CQ bit was checked by timav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org Link to the patchset: https://codereview.chromium.org/2701083002/#ps40001 (title: "Removed redundant EXPECTs in test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489629755886710,
"parent_rev": "67a26dc6928cf5dac2f2f2242f24ddb5b60e216b", "commit_rev":
"4e61755b3dd5d278d51896e56e4f9aa51beff6a2"}
Message was sent while issue was closed.
Description was changed from ========== Preserve handles visibility when modifying selection When modifying selection programmatically by the method FrameSelection::setSelectedRange preserve selection handles visibility. BUG=685420 ========== to ========== Preserve handles visibility when modifying selection When modifying selection programmatically by the method FrameSelection::setSelectedRange preserve selection handles visibility. BUG=685420 Review-Url: https://codereview.chromium.org/2701083002 Cr-Commit-Position: refs/heads/master@{#457341} Committed: https://chromium.googlesource.com/chromium/src/+/4e61755b3dd5d278d51896e56e4f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4e61755b3dd5d278d51896e56e4f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
