Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2701083002: Preserve handles visibility when modifying selection (Closed)
Patch Set: Removed redundant EXPECTs in test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 650
651 bool FrameSelection::setSelectedRange(const EphemeralRange& range, 651 bool FrameSelection::setSelectedRange(const EphemeralRange& range,
652 TextAffinity affinity, 652 TextAffinity affinity,
653 SelectionDirectionalMode directional, 653 SelectionDirectionalMode directional,
654 SetSelectionOptions options) { 654 SetSelectionOptions options) {
655 if (range.isNull()) 655 if (range.isNull())
656 return false; 656 return false;
657 setSelection(SelectionInDOMTree::Builder() 657 setSelection(SelectionInDOMTree::Builder()
658 .setBaseAndExtent(range) 658 .setBaseAndExtent(range)
659 .setAffinity(affinity) 659 .setAffinity(affinity)
660 .setIsHandleVisible(isHandleVisible())
660 .setIsDirectional(directional == 661 .setIsDirectional(directional ==
661 SelectionDirectionalMode::Directional) 662 SelectionDirectionalMode::Directional)
662 .build(), 663 .build(),
663 options); 664 options);
664 return true; 665 return true;
665 } 666 }
666 667
667 Range* FrameSelection::firstRange() const { 668 Range* FrameSelection::firstRange() const {
668 return m_selectionEditor->firstRange(); 669 return m_selectionEditor->firstRange();
669 } 670 }
(...skipping 486 matching lines...) Expand 10 before | Expand all | Expand 10 after
1156 } 1157 }
1157 1158
1158 void showTree(const blink::FrameSelection* sel) { 1159 void showTree(const blink::FrameSelection* sel) {
1159 if (sel) 1160 if (sel)
1160 sel->showTreeForThis(); 1161 sel->showTreeForThis();
1161 else 1162 else
1162 LOG(INFO) << "Cannot showTree for <null> FrameSelection."; 1163 LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
1163 } 1164 }
1164 1165
1165 #endif 1166 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698