Preserve handles visibility when modifying selection

third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameSelection.h"
 
 #include <memory>
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
@@ skipping 275 matching lines @@
                                .setIsHandleVisible(true)
                                .build());
   EXPECT_TRUE(selection().isHandleVisible());
   selection().selectAll();
   EXPECT_TRUE(selection().isHandleVisible())
       << "If handles were present before"
          "selectAll. Then they should be present"
          "after it.";
 }
 
+TEST_F(FrameSelectionTest, SetSelectedRangePreservesHandle) {
+  Text* text = appendTextNode("Hello, World!");
+  document().view()->updateAllLifecyclePhases();
+  selection().setSelection(
+      SelectionInDOMTree::Builder()
+          .setBaseAndExtent(Position(text, 0), Position(text, 5))
+          .setIsHandleVisible(false)
+          .build());
+  EXPECT_FALSE(selection().isHandleVisible());

[yosin_UTC9, 2017/03/16 01:10:26]

nit: Since other test covers this, we don't need to check it here. Please remove
this.

[Tima Vaisburd, 2017/03/16 02:02:29]

Done.

+
+  selection().setSelectedRange(
+      EphemeralRange(Position(text, 0), Position(text, 12)),
+      VP_DEFAULT_AFFINITY, SelectionDirectionalMode::NonDirectional, 0);
+
+  EXPECT_FALSE(selection().isHandleVisible())
+      << "If handles weren't present before"
+         "setSelectedRange they shouldn't be present"
+         "after it.";
+
+  selection().setSelection(
+      SelectionInDOMTree::Builder()
+          .setBaseAndExtent(Position(text, 0), Position(text, 5))
+          .setIsHandleVisible(true)
+          .build());
+  EXPECT_TRUE(selection().isHandleVisible());

[yosin_UTC9, 2017/03/16 01:10:26]

nit: Since other test covers this, we don't need to check it here. Please remove
this.

[Tima Vaisburd, 2017/03/16 02:02:29]

Done.

+
+  selection().setSelectedRange(
+      EphemeralRange(Position(text, 0), Position(text, 12)),
+      VP_DEFAULT_AFFINITY, SelectionDirectionalMode::NonDirectional, 0);
+
+  EXPECT_TRUE(selection().isHandleVisible())
+      << "If handles were present before"
+         "selectSetSelectedRange they should be present after it.";
+}
+
 }  // namespace blink