third_party/WebKit/Source/core/editing/FrameSelection.cpp - Issue 2701083002: Preserve handles visibility when modifying selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2701083002: Preserve handles visibility when modifying selection (Closed)

Patch Set: Removed redundant EXPECTs in test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

index 47629e3f994e2a57798b77ab0ff62148b0b21829..d45285793773acea87241e7fdb7a205f92b7e381 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp

@@ -657,6 +657,7 @@ bool FrameSelection::setSelectedRange(const EphemeralRange& range,

setSelection(SelectionInDOMTree::Builder()

.setBaseAndExtent(range)

.setAffinity(affinity)

+ .setIsHandleVisible(isHandleVisible())

.setIsDirectional(directional ==

SelectionDirectionalMode::Directional)

.build(),

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »