Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2700733002: Mechanical refactoring of the parser and ActionUpdateCheck (Closed)

Created:
3 years, 10 months ago by Sorin Jianu
Modified:
3 years, 10 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This refactors the component updater parser and the ActionUpdateCheck in preparation for handling the run action later on. BUG=687231 Review-Url: https://codereview.chromium.org/2700733002 Cr-Commit-Position: refs/heads/master@{#451087} Committed: https://chromium.googlesource.com/chromium/src/+/9ef301c52015be2aefde760bc560de502b2b94e1

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -84 lines) Patch
M components/update_client/action_update_check.h View 1 chunk +7 lines, -1 line 0 comments Download
M components/update_client/action_update_check.cc View 3 chunks +92 lines, -63 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 13 chunks +13 lines, -0 lines 0 comments Download
M components/update_client/update_response.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M components/update_client/update_response.cc View 2 chunks +28 lines, -17 lines 0 comments Download
M components/update_client/update_response_unittest.cc View 4 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (13 generated)
Sorin Jianu
PTAL
3 years, 10 months ago (2017-02-16 17:36:17 UTC) #8
waffles
lgtm
3 years, 10 months ago (2017-02-16 17:51:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700733002/20001
3 years, 10 months ago (2017-02-16 19:38:48 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 20:30:01 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ef301c52015be2aefde760bc560...

Powered by Google App Engine
This is Rietveld 408576698