Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/update_client/update_response.h

Issue 2700733002: Mechanical refactoring of the parser and ActionUpdateCheck (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/update_client_unittest.cc ('k') | components/update_client/update_response.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_response.h
diff --git a/components/update_client/update_response.h b/components/update_client/update_response.h
index 01b49aaafa9844ba036731909c8946c93cad5154..5f7ca5728717d2486ea5ee46d1f57d57f2b1a67b 100644
--- a/components/update_client/update_response.h
+++ b/components/update_client/update_response.h
@@ -95,6 +95,9 @@ class UpdateResponse {
std::string extension_id;
+ // The updatecheck response status.
+ std::string status;
+
// The list of fallback urls, for full and diff updates respectively.
// These urls are base urls; they don't include the filename.
std::vector<GURL> crx_urls;
@@ -130,8 +133,9 @@ class UpdateResponse {
// Parses an update response xml string into Result data. Returns a bool
// indicating success or failure. On success, the results are available by
- // calling results(). The details for any failures are available by calling
- // errors().
+ // calling results(). In case of success, only results corresponding to
+ // the update check status |ok| or |noupdate| are included.
+ // The details for any failures are available by calling errors().
bool Parse(const std::string& manifest_xml);
const Results& results() const { return results_; }
« no previous file with comments | « components/update_client/update_client_unittest.cc ('k') | components/update_client/update_response.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698