Mechanical refactoring of the parser and ActionUpdateCheck

components/update_client/update_response.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_
 #define COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 77 matching lines @@
       std::string browser_min_version;
       std::vector<Package> packages;
     };
 
     Result();
     Result(const Result& other);
     ~Result();
 
     std::string extension_id;
 
+    // The updatecheck response status.
+    std::string status;
+
     // The list of fallback urls, for full and diff updates respectively.
     // These urls are base urls; they don't include the filename.
     std::vector<GURL> crx_urls;
     std::vector<GURL> crx_diffurls;
 
     Manifest manifest;
 
     // The server has instructed the client to set its [key] to [value] for each
     // key-value pair in this string.
     std::map<std::string, std::string> cohort_attrs;
@@ skipping 15 matching lines @@
     // This will be >= 0, or kNoDaystart if the <daystart> tag was not present.
     int daystart_elapsed_days;
     std::vector<Result> list;
   };
 
   UpdateResponse();
   ~UpdateResponse();
 
   // Parses an update response xml string into Result data. Returns a bool
   // indicating success or failure. On success, the results are available by
-  // calling results(). The details for any failures are available by calling
-  // errors().
+  // calling results(). In case of success, only results corresponding to
+  // the update check status |ok| or |noupdate| are included.
+  // The details for any failures are available by calling errors().
   bool Parse(const std::string& manifest_xml);
 
   const Results& results() const { return results_; }
   const std::string& errors() const { return errors_; }
 
  private:
   Results results_;
   std::string errors_;
 
   // Adds parse error details to |errors_| string.
   void ParseError(const char* details, ...);
 
   DISALLOW_COPY_AND_ASSIGN(UpdateResponse);
 };
 
 }  // namespace update_client
 
 #endif  // COMPONENTS_UPDATE_CLIENT_UPDATE_RESPONSE_H_