Mechanical refactoring of the parser and ActionUpdateCheck

components/update_client/update_client_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
@@ skipping 357 matching lines @@
         </app>
       </response>
       */
       UpdateResponse::Result::Manifest::Package package;
       package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
 
       UpdateResponse::Result result;
       result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result.status = "ok";
       result.crx_urls.push_back(GURL("http://localhost/download/"));
       result.manifest.version = "1.0";
       result.manifest.browser_min_version = "11.0.1.0";
       result.manifest.packages.push_back(package);
 
       UpdateResponse::Results results;
       results.list.push_back(result);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(update_check_callback, 0, results, 0));
@@ skipping 181 matching lines @@
         </app>
       </response>
       */
       UpdateResponse::Result::Manifest::Package package1;
       package1.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package1.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
 
       UpdateResponse::Result result1;
       result1.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result1.status = "ok";
       result1.crx_urls.push_back(GURL("http://localhost/download/"));
       result1.manifest.version = "1.0";
       result1.manifest.browser_min_version = "11.0.1.0";
       result1.manifest.packages.push_back(package1);
 
       UpdateResponse::Result::Manifest::Package package2;
       package2.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx";
       package2.hash_sha256 =
           "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9";
 
       UpdateResponse::Result result2;
       result2.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+      result2.status = "ok";
       result2.crx_urls.push_back(GURL("http://localhost/download/"));
       result2.manifest.version = "1.0";
       result2.manifest.browser_min_version = "11.0.1.0";
       result2.manifest.packages.push_back(package2);
 
       UpdateResponse::Results results;
       results.list.push_back(result1);
       results.list.push_back(result2);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ skipping 217 matching lines @@
         </app>
       </response>
       */
       UpdateResponse::Result::Manifest::Package package1;
       package1.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package1.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
 
       UpdateResponse::Result result1;
       result1.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result1.status = "ok";
       result1.crx_urls.push_back(GURL("http://localhost/download/"));
       result1.manifest.version = "1.0";
       result1.manifest.browser_min_version = "11.0.1.0";
       result1.manifest.packages.push_back(package1);
 
       UpdateResponse::Result::Manifest::Package package2;
       package2.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx";
       package2.hash_sha256 =
           "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9";
 
       UpdateResponse::Result result2;
       result2.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+      result2.status = "ok";
       result2.crx_urls.push_back(GURL("http://localhost/download/"));
       result2.manifest.version = "1.0";
       result2.manifest.browser_min_version = "11.0.1.0";
       result2.manifest.packages.push_back(package2);
 
       UpdateResponse::Results results;
       results.list.push_back(result1);
       results.list.push_back(result2);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ skipping 211 matching lines @@
           </app>
         </response>
         */
         UpdateResponse::Result::Manifest::Package package;
         package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx";
         package.hash_sha256 =
             "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9";
         package.fingerprint = "1";
         UpdateResponse::Result result;
         result.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+        result.status = "ok";
         result.crx_urls.push_back(GURL("http://localhost/download/"));
         result.manifest.version = "1.0";
         result.manifest.browser_min_version = "11.0.1.0";
         result.manifest.packages.push_back(package);
         results.list.push_back(result);
       } else if (num_call == 2) {
         /*
         Fake the following response:
         <?xml version='1.0' encoding='UTF-8'?>
         <response protocol='3.0'>
@@ skipping 21 matching lines @@
         UpdateResponse::Result::Manifest::Package package;
         package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx";
         package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx";
         package.hash_sha256 =
             "1af337fbd19c72db0f870753bcd7711c3ae9dcaa0ecde26c262bad942b112990";
         package.hashdiff_sha256 =
             "73c6e2d4f783fc4ca5481e89e0b8bfce7aec8ead3686290c94792658ec06f2f2";
         package.fingerprint = "22";
         UpdateResponse::Result result;
         result.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+        result.status = "ok";
         result.crx_urls.push_back(GURL("http://localhost/download/"));
         result.crx_diffurls.push_back(GURL("http://localhost/download/"));
         result.manifest.version = "2.0";
         result.manifest.browser_min_version = "11.0.1.0";
         result.manifest.packages.push_back(package);
         results.list.push_back(result);
       } else {
         NOTREACHED();
       }
 
@@ skipping 227 matching lines @@
           </updatecheck>
         </app>
       </response>
       */
       UpdateResponse::Result::Manifest::Package package;
       package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
       UpdateResponse::Result result;
       result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result.status = "ok";
       result.crx_urls.push_back(GURL("http://localhost/download/"));
       result.manifest.version = "1.0";
       result.manifest.browser_min_version = "11.0.1.0";
       result.manifest.packages.push_back(package);
 
       UpdateResponse::Results results;
       results.list.push_back(result);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(update_check_callback, 0, results, 0));
@@ skipping 171 matching lines @@
           </app>
         </response>
         */
         UpdateResponse::Result::Manifest::Package package;
         package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx";
         package.hash_sha256 =
             "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9";
         package.fingerprint = "1";
         UpdateResponse::Result result;
         result.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+        result.status = "ok";
         result.crx_urls.push_back(GURL("http://localhost/download/"));
         result.manifest.version = "1.0";
         result.manifest.browser_min_version = "11.0.1.0";
         result.manifest.packages.push_back(package);
         results.list.push_back(result);
       } else if (num_call == 2) {
         /*
         Fake the following response:
         <?xml version='1.0' encoding='UTF-8'?>
         <response protocol='3.0'>
@@ skipping 21 matching lines @@
         UpdateResponse::Result::Manifest::Package package;
         package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx";
         package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx";
         package.hash_sha256 =
             "1af337fbd19c72db0f870753bcd7711c3ae9dcaa0ecde26c262bad942b112990";
         package.hashdiff_sha256 =
             "73c6e2d4f783fc4ca5481e89e0b8bfce7aec8ead3686290c94792658ec06f2f2";
         package.fingerprint = "22";
         UpdateResponse::Result result;
         result.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+        result.status = "ok";
         result.crx_urls.push_back(GURL("http://localhost/download/"));
         result.crx_diffurls.push_back(GURL("http://localhost/download/"));
         result.manifest.version = "2.0";
         result.manifest.browser_min_version = "11.0.1.0";
         result.manifest.packages.push_back(package);
         results.list.push_back(result);
       } else {
         NOTREACHED();
       }
 
@@ skipping 324 matching lines @@
           </updatecheck>
         </app>
       </response>
       */
       UpdateResponse::Result::Manifest::Package package;
       package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
       UpdateResponse::Result result;
       result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result.status = "ok";
       result.crx_urls.push_back(GURL("http://localhost/download/"));
       result.manifest.version = "1.0";
       result.manifest.browser_min_version = "11.0.1.0";
       result.manifest.packages.push_back(package);
 
       UpdateResponse::Results results;
       results.list.push_back(result);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(update_check_callback, 0, results, 0));
@@ skipping 596 matching lines @@
       // and further down to the UpdateChecker instance.
       EXPECT_FALSE(enabled_component_updates);
 
       UpdateResponse::Result::Manifest::Package package1;
       package1.name = "jebgalgnebhfojomionfpkfelancnnkf.crx";
       package1.hash_sha256 =
           "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87";
 
       UpdateResponse::Result result1;
       result1.extension_id = "jebgalgnebhfojomionfpkfelancnnkf";
+      result1.status = "ok";
       result1.crx_urls.push_back(GURL("http://localhost/download/"));
       result1.manifest.version = "1.0";
       result1.manifest.browser_min_version = "11.0.1.0";
       result1.manifest.packages.push_back(package1);
 
       UpdateResponse::Result::Manifest::Package package2;
       package2.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx";
       package2.hash_sha256 =
           "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9";
 
       UpdateResponse::Result result2;
       result2.extension_id = "ihfokbkgjpifnbbojhneepfflplebdkc";
+      result2.status = "ok";
       result2.crx_urls.push_back(GURL("http://localhost/download/"));
       result2.manifest.version = "1.0";
       result2.manifest.browser_min_version = "11.0.1.0";
       result2.manifest.packages.push_back(package2);
 
       UpdateResponse::Results results;
       results.list.push_back(result1);
       results.list.push_back(result2);
 
       base::ThreadTaskRunnerHandle::Get()->PostTask(
@@ skipping 121 matching lines @@
   update_client->Update(
       ids, base::Bind(&DataCallbackFake::Callback),
       base::Bind(&CompletionCallbackFake::Callback, quit_closure()));
 
   RunThreads();
 
   update_client->RemoveObserver(&observer);
 }
 
 }  // namespace update_client