DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible.

DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible.

BUG=693803
Review-Url: https://codereview.chromium.org/2700293002
Cr-Original-Commit-Position: refs/heads/master@{#452355}
Committed: https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa298450c23462
Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452667}
Committed: https://chromium.googlesource.com/chromium/src/+/fbd566a07bb73d4321780c44ac5ed0fb2ef342e0

[pfeldman, 2017-02-18 01:22:22]

pfeldman@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[pfeldman, 2017-02-21 19:27:55]

Description was changed from

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803
==========

to

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803
==========

[pfeldman, 2017-02-21 19:27:55]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org, dgozman@chromium.org

[pfeldman, 2017-02-21 19:30:50]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[pfeldman, 2017-02-21 19:31:47]

pfeldman@chromium.org changed reviewers:
+ caseq@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:31:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-21 19:38:14]

The CQ bit was unchecked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:38:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 19:38:28]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kozy, 2017-02-21 20:05:09]

lgtm

[alph, 2017-02-21 20:13:58]

lgtm

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/DOMTimer.cpp (right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/DOMTimer.cpp:99:
InspectorInstrumentation::asyncTaskScheduledBreakable(context, "setTimeout",
what happenned to setInterval?

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
(right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:93: if
(ThreadDebugger* debugger = ThreadDebugger::from(toIsolate(context)))
nit: asyncTaskScheduled(...)

[caseq, 2017-02-21 21:04:27]

lgtm

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
(right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:119:
return;
{} around this one.

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:122:
domDebuggerAgent->allowNativeBreakpoint(name, nullptr, true);
ditto.

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h
(right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h:73:
NativeBreakpoint m_breakpoint;
Perhaps there should be two separate classes AsyncTask and
AsyncTaskWithBreakpoint?

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/DocumentLoader.cpp (right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/DocumentLoader.cpp:32: #include <memory>
add empty line

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2700293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js:67:
this._createCategory(Common.UIString('Timer'), ['setTimeout', 'clearTimeout',
'timerFired'], true);
should it also mention interval?

[pfeldman, 2017-02-21 21:09:02]

all done, second class for task w/ break acknowledged.

[pfeldman, 2017-02-22 17:54:51]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-22 17:54:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, alph@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2700293002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-22 17:55:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 18:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:22:38]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[pfeldman, 2017-02-22 19:31:00]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:55:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-02-22 21:59:23]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-22 21:59:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, alph@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2700293002/#ps60001
(title: "tests fixed")

[commit-bot: I haz the power, 2017-02-22 22:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 23:16:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 23:16:48]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-02-23 00:38:13]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-23 00:38:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, alph@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2700293002/#ps80001
(title: "same")

[commit-bot: I haz the power, 2017-02-23 00:39:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-02-23 00:40:19]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2017-02-23 00:52:00]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-23 00:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, alph@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2700293002/#ps100001
(title: "Introduce progress monitor")

[commit-bot: I haz the power, 2017-02-23 00:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 02:40:30]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487811120831190,
"parent_rev": "65217792e655c9fa998f00b56b952192452b357c", "commit_rev":
"c0ff4c0d40a8b9ab8ed809a446aa298450c23462"}

[commit-bot: I haz the power, 2017-02-23 02:41:15]

Description was changed from

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803
==========

to

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803

Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452355}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...
==========

[commit-bot: I haz the power, 2017-02-23 02:41:16]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...

[findit-for-me, 2017-02-23 03:06:20]

FYI: Findit identified this CL at revision 452355 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[caseq, 2017-02-23 03:09:25]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2713613003/ by caseq@chromium.org.

The reason for reverting is: This broke build according to #39.

[pfeldman, 2017-02-23 21:18:32]

Description was changed from

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803

Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452355}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...
==========

to

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803

Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452355}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...
==========

[pfeldman, 2017-02-23 21:24:47]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-02-23 21:24:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, alph@chromium.org, caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2700293002/#ps120001
(title: "same with unused assert removed - assert is trivial")

[commit-bot: I haz the power, 2017-02-23 21:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:17:15]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487885087930420,
"parent_rev": "67ce2eef955ec99e685af794efe0d60a51d0d1de", "commit_rev":
"fbd566a07bb73d4321780c44ac5ed0fb2ef342e0"}

[commit-bot: I haz the power, 2017-02-23 23:17:53]

Description was changed from

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803

Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452355}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...
==========

to

==========
DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where
possible.

BUG=693803

Review-Url: https://codereview.chromium.org/2700293002
Cr-Original-Commit-Position: refs/heads/master@{#452355}
Committed:
https://chromium.googlesource.com/chromium/src/+/c0ff4c0d40a8b9ab8ed809a446aa...
Review-Url: https://codereview.chromium.org/2700293002
Cr-Commit-Position: refs/heads/master@{#452667}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbd566a07bb73d4321780c44ac5e...
==========

[commit-bot: I haz the power, 2017-02-23 23:17:54]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fbd566a07bb73d4321780c44ac5e...