Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1938)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (Closed)
Patch Set: same with unused assert removed - assert is trivial Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
index e03655ff83fdc2e23734b49a8aa3489a80e85d38..769c95f9a36e2280982ccceab008f5111e3ba1bf 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
@@ -180,8 +180,8 @@ void Geolocation::getCurrentPosition(PositionCallback* successCallback,
return;
reportGeolocationViolation(document());
- InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- document(), "Geolocation.getCurrentPosition", true);
+ InspectorInstrumentation::breakIfNeeded(document(),
+ "Geolocation.getCurrentPosition");
GeoNotifier* notifier =
GeoNotifier::create(this, successCallback, errorCallback, options);
@@ -197,8 +197,8 @@ int Geolocation::watchPosition(PositionCallback* successCallback,
return 0;
reportGeolocationViolation(document());
- InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(
- document(), "Geolocation.watchPosition", true);
+ InspectorInstrumentation::breakIfNeeded(document(),
+ "Geolocation.watchPosition");
GeoNotifier* notifier =
GeoNotifier::create(this, successCallback, errorCallback, options);

Powered by Google App Engine
This is Rietveld 408576698