third_party/WebKit/Source/core/dom/Document.cpp - Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (Closed)

Patch Set: same with unused assert removed - assert is trivial Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 43a8d63e8a15db28ab5e48b59545182c2da6a3f4..e70bfb8ccbe5802e68441d2e7333a73d7acbff28 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -3231,8 +3231,7 @@ void Document::write(const SegmentedString& text,

PerformanceMonitor::reportGenericViolation(

this, PerformanceMonitor::kDiscouragedAPIUse,

"Avoid using document.write().", 0, nullptr);

- InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(

- this, "Document.write", true);

+ InspectorInstrumentation::breakIfNeeded(this, "Document.write");

m_parser->insert(text);

}