third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2700293002: DevTools: do not use RAII for sync native breakpoints, reuse AsyncTask where possible. (Closed)

Patch Set: same with unused assert removed - assert is trivial Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 6b33d2435489b7e496174e21edf286f28441d02a..e6d1258255f20d423dafe7571b0d950e07233cc0 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -378,8 +378,7 @@ void DOMWindow::close(ExecutionContext* context) {

if (!frame()->shouldClose())

return;

- InspectorInstrumentation::NativeBreakpoint nativeBreakpoint(

- context, "DOMWindow.close", true);

+ InspectorInstrumentation::breakIfNeeded(context, "DOMWindow.close");

page->closeSoon();