Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2697313005: Selection API: collapse() should recreate an internal Range. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: collapse() should recreate an internal Range. This CL fixes 1,354 tests in external/wpt/selection/. Some existing tests needs to check visual caret position. So this CL introduces internals.visibleSelection{AnchorNode,AnchorOffset,FocusNode,FocusOffset} for them. BUG=692400 Review-Url: https://codereview.chromium.org/2697313005 Cr-Commit-Position: refs/heads/master@{#451277} Committed: https://chromium.googlesource.com/chromium/src/+/1227e8921776ed2ba4b5497a228f2e2c4143ed23

Patch Set 1 #

Patch Set 2 : Add NeedsRebaseline for platform-dependent tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1581 lines, -2905 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/pasteboard/paste-text-with-style-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_before_select.html View 1 chunk +11 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_document_in_design_mode.html View 1 chunk +10 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_html_to_editable_body.html View 1 chunk +10 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html View 1 chunk +9 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-3.html View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/home-end-expected.txt View 1 chunk +84 lines, -84 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/modify_move/resources/move-by-word-visually.js View 4 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/move-left-right.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/skip-not-adjacent-contenteditable.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/skip-not-adjacent-contenteditable-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/table-caret-1.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/unrendered-001.html View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/unrendered-space.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt View 78 chunks +688 lines, -1403 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt View 61 chunks +668 lines, -1364 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yosin@, yoichio@, would you review this please?
3 years, 10 months ago (2017-02-17 06:09:02 UTC) #4
yoichio
lgtm
3 years, 10 months ago (2017-02-17 07:32:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697313005/20001
3 years, 10 months ago (2017-02-17 07:53:47 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 10:25:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1227e8921776ed2ba4b5497a228f...

Powered by Google App Engine
This is Rietveld 408576698