third_party/WebKit/LayoutTests/editing/selection/move-left-right.html - Issue 2697313005: Selection API: collapse() should recreate an internal Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/move-left-right.html

Issue 2697313005: Selection API: collapse() should recreate an internal Range. (Closed)

Patch Set: Add NeedsRebaseline for platform-dependent tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/modify_move/resources/move-by-word-visually.js ('k') | third_party/WebKit/LayoutTests/editing/selection/skip-not-adjacent-contenteditable.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/move-left-right.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/move-left-right.html b/third_party/WebKit/LayoutTests/editing/selection/move-left-right.html

index 4b90e5b74542cc64c57758c2f493abc06dfae08e..9a91f7245ae71c6f8a1cb26f65188699d02c7aaa 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/move-left-right.html

+++ b/third_party/WebKit/LayoutTests/editing/selection/move-left-right.html

@@ -41,9 +41,9 @@

{

var positions = [];

while (true) {

- positions.push({ node: sel.anchorNode, offset: sel.anchorOffset, point: caretCoordinates() });

+ positions.push({ node: internals.visibleSelectionAnchorNode, offset: internals.visibleSelectionAnchorOffset, point: caretCoordinates() });

sel.modify("move", direction, "character");

- if (positions[positions.length - 1].node == sel.anchorNode && positions[positions.length - 1].offset == sel.anchorOffset)

+ if (positions[positions.length - 1].node == internals.visibleSelectionAnchorNode && positions[positions.length - 1].offset == internals.visibleSelectionAnchorOffset)

break;

};

return positions;