third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html - Issue 2697313005: Selection API: collapse() should recreate an internal Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html

Issue 2697313005: Selection API: collapse() should recreate an internal Range. (Closed)

Patch Set: Add NeedsRebaseline for platform-dependent tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_html_to_editable_body.html ('k') | third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-3.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html b/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html

index 053134f663a60da3ab72869a2299f94eb8ad6053..59ab1384f917f2e2b1ddb805fb25e5133b59c01a 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html

+++ b/third_party/WebKit/LayoutTests/editing/selection/collapse/table-caret-2.html

@@ -12,9 +12,15 @@ table, td {

test(function () {

var selection = window.getSelection();

- selection.collapse(sample, sample.childNodes.length);

+ let childLength = sample.childNodes.length;

+ selection.collapse(sample, childLength);

assert_true(selection.isCollapsed, 'isCollapsed');

- assert_equals(selection.anchorNode, div, 'anchorNode');

- assert_equals(selection.anchorOffset, 2, 'anchorOffset');

+ assert_equals(selection.anchorNode, sample, 'DOM anchorNode');

+ assert_equals(selection.anchorOffset, childLength, 'DOM anchorOffset');

+ assert_exists(window, 'internals');

+ assert_equals(internals.visibleSelectionAnchorNode, div, 'Canonicalized anchorNode');

+ assert_equals(internals.visibleSelectionAnchorOffset, 2, 'Canonicalized anchorOffset');

});

</script>