third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html - Issue 2697313005: Selection API: collapse() should recreate an internal Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html

Issue 2697313005: Selection API: collapse() should recreate an internal Range. (Closed)

Patch Set: Add NeedsRebaseline for platform-dependent tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html b/third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html

index 6256ea039452d516d88d713288f1a5737072b59c..fc3250829f468632127ec894c7d5c21eb25f5780 100644

--- a/third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html

+++ b/third_party/WebKit/LayoutTests/editing/deleting/typing_one_character_delete_crash.html

@@ -13,9 +13,6 @@

selection.document.execCommand('insertText', false, 'x');

selection.document.execCommand('delete');

- // TODO(yosin): Once visible position canonicalization is fixed,

- // the expectation should be:

- // '<div contenteditable>|<div><span></span></div></div>'

- '<div contenteditable><div><span></span></div></div>'),

+ '<div contenteditable><div><span>|</span></div></div>'),

'Should not crash after typing one chracter then delete it');

</script>