color: Add support for shader generation

color: Add support for shader generation

Add a cache of ColorTransform objects to GLRenderer. If the
ColorTransform is not a no-op or a LUT, use the pointer to the
ColorTransform as part of the ProgramKey.

Add methods to ColorTranform to generate shader code, and implement
these methods for no-op and matrix-multiply color transform steps.

Remove the YUV matrix from ProgramBinding because it is now covered
by either the LUT or by the shader generation.

Add the behavior that if the destination color space is not specified,
then only the YUV to RGB conversion of the source color space is
performed, so that we can use this before enabling color conversion at
large.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2697253002
Cr-Commit-Position: refs/heads/master@{#451447}
Committed: https://chromium.googlesource.com/chromium/src/+/ecdfdf5b38b44e99023608dac72afa4f6d293d8a

[ccameron, 2017-02-16 03:57:54]

Description was changed from

==========
color: Add support for shader generation

Add a cache of ColorTransform objects to GLRenderer. If the
ColorTransform is not a no-op or a LUT, use the pointer to the
ColorTransform as part of the ProgramKey.

Add methods to ColorTranform to generate shader code, and implement
these methods for no-op and matrix-multiply color transform steps.

Remove the YUV matrix from ProgramBinding because it is now covered
by either the LUT or by the shader generation.

Add the behavior that if the destination color space is not specified,
then only the YUV to RGB conversion of the source color space is
performed, so that we can use this before enabling color conversion at
large.

BUG=667966
==========

to

==========
color: Add support for shader generation

Add a cache of ColorTransform objects to GLRenderer. If the
ColorTransform is not a no-op or a LUT, use the pointer to the
ColorTransform as part of the ProgramKey.

Add methods to ColorTranform to generate shader code, and implement
these methods for no-op and matrix-multiply color transform steps.

Remove the YUV matrix from ProgramBinding because it is now covered
by either the LUT or by the shader generation.

Add the behavior that if the destination color space is not specified,
then only the YUV to RGB conversion of the source color space is
performed, so that we can use this before enabling color conversion at
large.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-16 04:10:56]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org, hubbe@chromium.org

[ccameron, 2017-02-16 04:10:57]

ptal

enne@ for cc/
hubbe@ for ui/color

[enne (OOO), 2017-02-16 18:45:59]

lgtm

[hubbe, 2017-02-16 20:53:53]

lgtm

https://codereview.chromium.org/2697253002/diff/20001/cc/output/program_bindi...
File cc/output/program_binding.cc (right):

https://codereview.chromium.org/2697253002/diff/20001/cc/output/program_bindi...
cc/output/program_binding.cc:141: color_conversion_mode_ =
COLOR_CONVERSION_MODE_LUT;
Can we save the transform here too and use it to generate the LUT from inside
shader.cc. Seems like it would be more consistent with how the other two cases
are handled.

[ccameron, 2017-02-16 22:33:52]

Good point-- I had been going back and forth on using the same ColorTransform in
ColorLUTCache. I've updated ColorLUTCache to use the same ColorTransform (and
use it as the key).

https://codereview.chromium.org/2697253002/diff/20001/cc/output/program_bindi...
File cc/output/program_binding.cc (right):

https://codereview.chromium.org/2697253002/diff/20001/cc/output/program_bindi...
cc/output/program_binding.cc:141: color_conversion_mode_ =
COLOR_CONVERSION_MODE_LUT;
On 2017/02/16 20:53:53, hubbe wrote:
> Can we save the transform here too and use it to generate the LUT from inside
> shader.cc. Seems like it would be more consistent with how the other two cases
> are handled.

I've updated the patch to use the ColorTransform in ColorLUTCache (instead of
re-computing it).

I'm leaving the ColorTransform out of the ProgramKey for LUT because the
generated program doesn't depend on it -- this way, we can re-use the same
program with different LUTs, rather than have to re-build the program for each
new color space pair.

[hubbe, 2017-02-16 23:00:33]

lgtm

[ccameron, 2017-02-17 01:35:23]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:37:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 03:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:13:58]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ccameron, 2017-02-18 00:43:03]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 00:44:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:46:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:46:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[ccameron, 2017-02-18 07:35:25]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-02-18 07:35:26]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2697253002/#ps60001
(title: "More bits of precision")

[commit-bot: I haz the power, 2017-02-18 07:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 09:13:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487403325684170,
"parent_rev": "69415b51072fb20605fc129f136950f7c2560ceb", "commit_rev":
"ecdfdf5b38b44e99023608dac72afa4f6d293d8a"}

[commit-bot: I haz the power, 2017-02-18 09:13:50]

Description was changed from

==========
color: Add support for shader generation

Add a cache of ColorTransform objects to GLRenderer. If the
ColorTransform is not a no-op or a LUT, use the pointer to the
ColorTransform as part of the ProgramKey.

Add methods to ColorTranform to generate shader code, and implement
these methods for no-op and matrix-multiply color transform steps.

Remove the YUV matrix from ProgramBinding because it is now covered
by either the LUT or by the shader generation.

Add the behavior that if the destination color space is not specified,
then only the YUV to RGB conversion of the source color space is
performed, so that we can use this before enabling color conversion at
large.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
color: Add support for shader generation

Add a cache of ColorTransform objects to GLRenderer. If the
ColorTransform is not a no-op or a LUT, use the pointer to the
ColorTransform as part of the ProgramKey.

Add methods to ColorTranform to generate shader code, and implement
these methods for no-op and matrix-multiply color transform steps.

Remove the YUV matrix from ProgramBinding because it is now covered
by either the LUT or by the shader generation.

Add the behavior that if the destination color space is not specified,
then only the YUV to RGB conversion of the source color space is
performed, so that we can use this before enabling color conversion at
large.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2697253002
Cr-Commit-Position: refs/heads/master@{#451447}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecdfdf5b38b44e99023608dac72a...
==========

[commit-bot: I haz the power, 2017-02-18 09:13:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ecdfdf5b38b44e99023608dac72a...