Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2696333002: Revert of Fix EXT_draw_buffers detection on some GL ES 3 contexts (Closed)

Created:
3 years, 10 months ago by Kai Ninomiya
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix EXT_draw_buffers detection on some GL ES 3 contexts (patchset #10 id:180001 of https://codereview.chromium.org/2678483003/ ) Reason for revert: Failures on waterfall almost certainly due to this CL Original issue's description: > Fix EXT_draw_buffers detection on some GL ES 3 contexts > > This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla ES3. > > This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google Pixel). > > BUG=688632 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2678483003 > Cr-Commit-Position: refs/heads/master@{#450804} > Committed: https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea30ca140e0a4d TBR=zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688632 Review-Url: https://codereview.chromium.org/2696333002 Cr-Commit-Position: refs/heads/master@{#450846} Committed: https://chromium.googlesource.com/chromium/src/+/81ee0eb7c58ddf35cce08886ab5a6d4fc4303b71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -20 lines) Patch
M gpu/command_buffer/service/context_group.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +19 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Kai Ninomiya
Created Revert of Fix EXT_draw_buffers detection on some GL ES 3 contexts
3 years, 10 months ago (2017-02-16 00:48:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696333002/1
3 years, 10 months ago (2017-02-16 00:49:22 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 00:51:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/81ee0eb7c58ddf35cce08886ab5a...

Powered by Google App Engine
This is Rietveld 408576698