Fix EXT_draw_buffers detection on some GL ES 3 contexts

Fix EXT_draw_buffers detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Original-Commit-Position: refs/heads/master@{#450804}
Committed: https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea30ca140e0a4d
Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#451360}
Committed: https://chromium.googlesource.com/chromium/src/+/313016af0d837cfcc8ee3ccd19145f46eebc0b10

[Kai Ninomiya, 2017-02-04 02:23:46]

Description was changed from

==========
Fix max_color_attachments detection on some GL ES 3 contexts

BUG=688632
==========

to

==========
Fix max_color_attachments detection on some GL ES 3 contexts

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-02-04 02:24:17]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[Kai Ninomiya, 2017-02-04 02:24:35]

zmo, PTAL (unless the dry run fails)

[commit-bot: I haz the power, 2017-02-04 02:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-02-04 02:25:53]

Description was changed from

==========
Fix max_color_attachments detection on some GL ES 3 contexts

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix max_color_attachments detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel)

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-02-04 02:26:12]

kainino@chromium.org changed reviewers:
+ zmo@chromium.org

[Kai Ninomiya, 2017-02-04 02:26:13]

zmo, PTAL (unless the dry run fails)

[commit-bot: I haz the power, 2017-02-04 03:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 03:17:01]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Kai Ninomiya, 2017-02-04 03:17:52]

On 2017/02/04 02:26:13, Kai Ninomiya wrote:
> zmo, PTAL (unless the dry run fails)

oh, I forgot to update unit tests. You can wait until I do that.

[Kai Ninomiya, 2017-02-08 01:34:20]

Description was changed from

==========
Fix max_color_attachments detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel)

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix ext_draw_buffers detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel)

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-02-09 01:12:43]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 01:13:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 02:07:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:07:17]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2017-02-14 01:13:20]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:14:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:52:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Kai Ninomiya, 2017-02-14 02:14:54]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 02:15:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-02-14 02:29:41]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 02:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-02-14 02:57:00]

The CQ bit was unchecked by kainino@chromium.org

[Kai Ninomiya, 2017-02-14 04:31:04]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 04:31:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 06:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 06:06:12]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Kai Ninomiya, 2017-02-14 23:35:06]

Description was changed from

==========
Fix ext_draw_buffers detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel)

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Kai Ninomiya, 2017-02-14 23:39:03]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 23:39:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 01:36:43]

Dry run: This issue passed the CQ dry run.

[Kai Ninomiya, 2017-02-15 01:42:15]

On the 9th try, I think this is finally good.

zmo: PTAL.

[Zhenyao Mo, 2017-02-15 18:42:37]

lgtm

Can you also remove NV_draw_buffers support from ANGLE?

https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
gpu/command_buffer/service/feature_info.cc:1157: gl_version_info_->is_es3 ||
nit: probably put the last two conditions first as they are cheaper and will be
hit more often.

[Kai Ninomiya, 2017-02-15 19:24:47]

The CQ bit was checked by kainino@chromium.org

[Kai Ninomiya, 2017-02-15 19:24:47]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2678483003/#ps180001
(title: "address comment")

[commit-bot: I haz the power, 2017-02-15 19:26:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2017-02-15 21:20:05]

On 2017/02/15 18:42:37, Zhenyao Mo wrote:
> lgtm
> 
> Can you also remove NV_draw_buffers support from ANGLE?

Do you mean removing NV_draw_buffers from the set of extensions supported by
ANGLE? Or removing the shader compiler's EXT-on-NV emulation path that we're not
using anymore?

>
https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
> gpu/command_buffer/service/feature_info.cc:1157: gl_version_info_->is_es3 ||
> nit: probably put the last two conditions first as they are cheaper and will
be
> hit more often.

Done

[commit-bot: I haz the power, 2017-02-15 21:25:15]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1487186687247390,
"parent_rev": "0572d4c5d2d90fe0ff3e56ce17949ab8389e4c9f", "commit_rev":
"252e09263e39d4e06b2a9dc094ea30ca140e0a4d"}

[commit-bot: I haz the power, 2017-02-15 21:25:55]

Description was changed from

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
==========

[commit-bot: I haz the power, 2017-02-15 21:25:57]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...

[Zhenyao Mo, 2017-02-15 23:27:03]

On 2017/02/15 21:20:05, Kai Ninomiya wrote:
> On 2017/02/15 18:42:37, Zhenyao Mo wrote:
> > lgtm
> > 
> > Can you also remove NV_draw_buffers support from ANGLE?
> 
> Do you mean removing NV_draw_buffers from the set of extensions supported by
> ANGLE? Or removing the shader compiler's EXT-on-NV emulation path that we're
not
> using anymore?

Both.  All traces of NV_draw_buffers in ANGLE can be removed because it's no
longer needed.  Dead code is bad.

> 
> >
>
https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
> > File gpu/command_buffer/service/feature_info.cc (right):
> > 
> >
>
https://codereview.chromium.org/2678483003/diff/160001/gpu/command_buffer/ser...
> > gpu/command_buffer/service/feature_info.cc:1157: gl_version_info_->is_es3 ||
> > nit: probably put the last two conditions first as they are cheaper and will
> be
> > hit more often.
> 
> Done

[Kai Ninomiya, 2017-02-16 00:48:11]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/2696333002/ by kainino@chromium.org.

The reason for reverting is: Failures on waterfall almost certainly due to this
CL.

[Kai Ninomiya, 2017-02-16 00:54:00]

Description was changed from

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
==========

to

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
==========

[Kai Ninomiya, 2017-02-16 21:53:25]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 21:54:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 23:12:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 23:12:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Kai Ninomiya, 2017-02-17 02:19:51]

The CQ bit was checked by kainino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 02:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 04:24:49]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Kai Ninomiya, 2017-02-17 18:32:08]

zmo, PTAL again

[Zhenyao Mo, 2017-02-17 19:17:44]

lgtm

https://codereview.chromium.org/2678483003/diff/220001/gpu/command_buffer/ser...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2678483003/diff/220001/gpu/command_buffer/ser...
gpu/command_buffer/service/feature_info.cc:1167:
can_emulate_es2_draw_buffers_on_es3_nv);
This is neat, much more readable

[Kai Ninomiya, 2017-02-17 19:28:19]

The CQ bit was checked by kainino@chromium.org

[commit-bot: I haz the power, 2017-02-17 19:29:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:55:26]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1487359699052760,
"parent_rev": "9e2a2c4db708e93db250dc00c6b6899a3dad8229", "commit_rev":
"313016af0d837cfcc8ee3ccd19145f46eebc0b10"}

[commit-bot: I haz the power, 2017-02-17 19:56:02]

Description was changed from

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
==========

to

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Original-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#451360}
Committed:
https://chromium.googlesource.com/chromium/src/+/313016af0d837cfcc8ee3ccd1914...
==========

[commit-bot: I haz the power, 2017-02-17 19:56:03]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/313016af0d837cfcc8ee3ccd1914...

[Kai Ninomiya, 2017-02-17 20:01:02]

> This also disables ES2 EXT_draw_buffers emulation on top of
ES3+NV_draw_buffers as it's not needed anymore - EXT_draw_buffers can now be
emulated on vanilla ES3.

Oops, this part of the commit message is wrong. I forgot to update the
description.

[Kai Ninomiya, 2017-02-17 20:01:14]

Description was changed from

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This also disables ES2 EXT_draw_buffers emulation on top of ES3+NV_draw_buffers
as it's not needed anymore - EXT_draw_buffers can now be emulated on vanilla
ES3.

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Original-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#451360}
Committed:
https://chromium.googlesource.com/chromium/src/+/313016af0d837cfcc8ee3ccd1914...
==========

to

==========
Fix EXT_draw_buffers detection on some GL ES 3 contexts

This is important on some native GL ES 3 contexts (e.g. Qualcomm on Google
Pixel).

BUG=688632
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2678483003
Cr-Original-Commit-Position: refs/heads/master@{#450804}
Committed:
https://chromium.googlesource.com/chromium/src/+/252e09263e39d4e06b2a9dc094ea...
Review-Url: https://codereview.chromium.org/2678483003
Cr-Commit-Position: refs/heads/master@{#451360}
Committed:
https://chromium.googlesource.com/chromium/src/+/313016af0d837cfcc8ee3ccd1914...
==========