Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: gpu/command_buffer/service/test_helper.cc

Issue 2696333002: Revert of Fix EXT_draw_buffers detection on some GL ES 3 contexts (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/test_helper.cc
diff --git a/gpu/command_buffer/service/test_helper.cc b/gpu/command_buffer/service/test_helper.cc
index fd5ef79921bb1a7c6ab64ea7461de08394dd6633..ab4105f3c7761ced0aae854214c061116a73cbc0 100644
--- a/gpu/command_buffer/service/test_helper.cc
+++ b/gpu/command_buffer/service/test_helper.cc
@@ -365,8 +365,9 @@
.RetiresOnSaturation();
}
- if (enable_es3 || strstr(extensions, "GL_ARB_draw_buffers") ||
- strstr(extensions, "GL_EXT_draw_buffers") || gl_info.is_es3 ||
+ if (strstr(extensions, "GL_EXT_draw_buffers") ||
+ strstr(extensions, "GL_ARB_draw_buffers") ||
+ (gl_info.is_es3 && strstr(extensions, "GL_NV_draw_buffers")) ||
gl_info.is_desktop_core_profile) {
EXPECT_CALL(*gl, GetIntegerv(GL_MAX_COLOR_ATTACHMENTS_EXT, _))
.WillOnce(SetArgumentPointee<1>(8))
@@ -655,8 +656,9 @@
#endif
}
- if (enable_es3 || strstr(extensions, "GL_ARB_draw_buffers") ||
- strstr(extensions, "GL_EXT_draw_buffers") || gl_info.is_es3 ||
+ if (strstr(extensions, "GL_EXT_draw_buffers") ||
+ strstr(extensions, "GL_ARB_draw_buffers") ||
+ (gl_info.is_es3 && strstr(extensions, "GL_NV_draw_buffers")) ||
gl_info.is_desktop_core_profile) {
EXPECT_CALL(*gl, GetIntegerv(GL_MAX_COLOR_ATTACHMENTS_EXT, _))
.WillOnce(SetArgumentPointee<1>(8))
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698