Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPT importer: Log CL status and consider "lgtm" success. Follow-up to http://crrev.com/2678773003. The behavior of the test importer still isn't quite right -- for example, in https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7959 in the "update css" step, it finished and the CQ was successful, but it wasn't committed... BUG=682092 Review-Url: https://codereview.chromium.org/2696263004 Cr-Commit-Position: refs/heads/master@{#451159} Committed: https://chromium.googlesource.com/chromium/src/+/a993acdd3083225868d472a30a2dc6d6c043c7dc

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
qyearsley
I'll remove the TBR in the description in a minute; I added that there to ...
3 years, 10 months ago (2017-02-16 18:33:38 UTC) #1
jeffcarp
lgtm
3 years, 10 months ago (2017-02-16 20:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696263004/40001
3 years, 10 months ago (2017-02-16 23:40:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 00:52:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a993acdd3083225868d472a30a2d...

Powered by Google App Engine
This is Rietveld 408576698