third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py - Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py

Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success. (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py

index 4522f249c96e5d08be9fc167fa80d3580da32c4d..a47a938188ba81a404b3d57073a0ee8743513a0a 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py

@@ -69,10 +69,6 @@ class GitCL(object):

self._host.filesystem.remove(results_path)

return json.loads(contents)

- def is_closed(self):

- out = self.run(['status' '--field', 'status'])

- return out.strip() == 'closed'

@staticmethod

def all_jobs_finished(try_results):

return all(r.get('status') == 'COMPLETED' for r in try_results)

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py » ('j') | no next file with comments »