third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py - Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success. (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

index 3127b459da5ffcadd350709a2f4e94056b0d5c7e..d7d8895057f70f5f0216777444c256c946a1df99 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py

@@ -354,7 +354,9 @@ class TestImporter(object):

return False

# If the CQ passes, then the issue will be closed.

- if not self.git_cl.is_closed():

+ status = self.git_cl.run(['status' '--field', 'status']).strip()

+ _log.info('CL status: "%s"', status)

+ if status not in ('lgtm', 'closed'):

_log.error('CQ appears to have failed; aborting.')

self.git_cl.run(['set-close'])

return False

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py ('k') | no next file » | no next file with comments »