third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py - Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

Issue 2696263004: WPT importer: Log CL status and consider "lgtm" success. (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

index b747083bad878a1023d7ca45958b93e579b30634..7c47ebccffea4a03e6ca6a001739b7552ee7dd64 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py

@@ -47,18 +47,6 @@ class GitCLTest(unittest.TestCase):

git_cl = GitCL(host)

self.assertEqual(git_cl.get_issue_number(), 'None')

- def test_is_closed_true(self):

- host = MockHost()

- host.executive = MockExecutive(output='closed ')

- git_cl = GitCL(host)

- self.assertTrue(git_cl.is_closed())

- def test_is_closed_false(self):

- host = MockHost()

- host.executive = MockExecutive(output='waiting')

- git_cl = GitCL(host)

- self.assertFalse(git_cl.is_closed())

def test_all_jobs_finished_empty(self):

self.assertTrue(GitCL.all_jobs_finished([]))