Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the spec…

Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html

This CL fixes 2056 sub-tests in external/wpt/selection/.

BUG=692400
Review-Url: https://codereview.chromium.org/2695193002
Cr-Commit-Position: refs/heads/master@{#450876}
Committed: https://chromium.googlesource.com/chromium/src/+/de65c2b24fc750fd8aee253b2be3600bf1a6555b

[tkent, 2017-02-15 02:36:45]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 02:37:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 04:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 04:33:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-02-15 08:03:36]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

BUG=
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

BUG=692400
==========

[tkent, 2017-02-15 08:20:25]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 08:20:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-15 08:22:15]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

BUG=692400
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleView.js

BUG=692400
==========

[tkent, 2017-02-15 08:23:25]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleView.js

BUG=692400
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.



BUG=692400
==========

[tkent, 2017-02-15 08:25:14]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.



BUG=692400
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html


BUG=692400
==========

[tkent, 2017-02-15 08:28:52]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html


BUG=692400
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html

This CL fixes 2056 sub-tests in external/wpt/selection/.

BUG=692400
==========

[tkent, 2017-02-15 08:28:52]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-15 08:29:09]

yoichio@, yosin@, would you review this please?

[commit-bot: I haz the power, 2017-02-15 08:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 08:32:45]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[yoichio, 2017-02-15 08:36:26]

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:106: if (!frame() ||
isBaseFirstInSelection())
What's the difference?

[tkent, 2017-02-15 08:49:49]

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:106: if (!frame() ||
isBaseFirstInSelection())
On 2017/02/15 at 08:36:25, yoichio wrote:
> What's the difference?

VisibleSelection-based detection doesn't work if
 - Backwards selection (extent/focus <- base/anchor), AND
 - Two positions are visibly-collapsed to one position.

In such case, visibleSelection().isBaseFirst() returns true even if it's
backwards. SelectionInDOMTree-based detection works well.

[yoichio, 2017-02-15 08:55:57]

lgtm

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2695193002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:106: if (!frame() ||
isBaseFirstInSelection())
On 2017/02/15 08:49:48, tkent wrote:
> On 2017/02/15 at 08:36:25, yoichio wrote:
> > What's the difference?
> 
> VisibleSelection-based detection doesn't work if
>  - Backwards selection (extent/focus <- base/anchor), AND
>  - Two positions are visibly-collapsed to one position.
> 
> In such case, visibleSelection().isBaseFirst() returns true even if it's
> backwards. SelectionInDOMTree-based detection works well.

Acknowledged.

[tkent, 2017-02-15 22:52:16]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 22:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:21:49]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[tkent, 2017-02-16 00:22:01]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2017-02-16 00:22:05]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-16 00:22:06]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2695193002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-16 00:23:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:55:32]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[tkent, 2017-02-16 01:06:48]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:08:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:11:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[tkent, 2017-02-16 03:18:45]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:23:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:23:08]

Exceeded global retry quota

[tkent, 2017-02-16 05:41:49]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:42:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:25:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487223709147190,
"parent_rev": "90cfee2509916bf517552bd6f69acb9d5086aeaf", "commit_rev":
"de65c2b24fc750fd8aee253b2be3600bf1a6555b"}

[commit-bot: I haz the power, 2017-02-16 06:26:48]

Description was changed from

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html

This CL fixes 2056 sub-tests in external/wpt/selection/.

BUG=692400
==========

to

==========
Selection API: setBaseAndExtent() and selectAllChildren() should create new
Range based on the specified nodes.

* ConsoleViewport._textOffsetInNode():
  It supported only Text node |container|. This CL adds Element support.

This CL removes the following tests because they are covered
by external/wpt/selection/:
 - editing/selection/getRangeAt.html
 - editing/selection/select_all/select_all_html.html
 - editing/selection/set_base_and_extent/set_base_and_extent_html.html

This CL fixes 2056 sub-tests in external/wpt/selection/.

BUG=692400

Review-Url: https://codereview.chromium.org/2695193002
Cr-Commit-Position: refs/heads/master@{#450876}
Committed:
https://chromium.googlesource.com/chromium/src/+/de65c2b24fc750fd8aee253b2be3...
==========

[commit-bot: I haz the power, 2017-02-16 06:26:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de65c2b24fc750fd8aee253b2be3...