Selection API: extend() should operate DOM Ranges.

Selection API: extend() should operate DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
Review-Url: https://codereview.chromium.org/2704443002
Cr-Commit-Position: refs/heads/master@{#450962}
Committed: https://chromium.googlesource.com/chromium/src/+/4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6

[tkent, 2017-02-16 03:19:29]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-02-16 03:19:53]

Description was changed from

==========
Selection API: extend() should operate based on DOM Rages.

This CL introduces 1,856 new PASSes in external/wpt/selection/.

BUG=692400
==========

to

==========
Selection API: extend() should operate based on DOM Rages.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

[commit-bot: I haz the power, 2017-02-16 03:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 04:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:57:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-02-16 05:05:38]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 05:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-16 05:07:58]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-16 06:01:34]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[tkent, 2017-02-16 06:02:01]

Patchset #1 (id:10001) has been deleted

[commit-bot: I haz the power, 2017-02-16 06:03:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-16 06:03:32]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-16 06:03:33]

yosin@, yoichio@, would you review this please?

[tkent, 2017-02-16 06:26:25]

Description was changed from

==========
Selection API: extend() should operate based on DOM Rages.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

to

==========
Selection API: extend() should operate based on DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

[yoichio, 2017-02-16 07:26:05]

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:448: Position
newFocus(node, offset);
Could you declare |const Position newFocus| ?

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:476: // 8. Set the
context object's range to newRange.
How about following code to share?:

SelectionInDOMTree::Builder builder;
builder.setIsDirectional(true);
if (newRange->collapsed())
 builder.collapse(..)
else
 builder.collapse(..).extend()

setSelection(builder.build());

[yosin_UTC9, 2017-02-16 07:33:53]

lgtm

[tkent, 2017-02-16 08:14:38]

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:448: Position
newFocus(node, offset);
On 2017/02/16 at 07:26:05, yoichio wrote:
> Could you declare |const Position newFocus| ?

Yes, done.

https://codereview.chromium.org/2704443002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:476: // 8. Set the
context object's range to newRange.
On 2017/02/16 at 07:26:05, yoichio wrote:
> How about following code to share?:
> 
> SelectionInDOMTree::Builder builder;
> builder.setIsDirectional(true);
> if (newRange->collapsed())
>  builder.collapse(..)
> else
>  builder.collapse(..).extend()
> 
> setSelection(builder.build());

Done.

[yoichio, 2017-02-16 08:42:34]

lgtm

[yosin_UTC9, 2017-02-16 10:05:41]

https://codereview.chromium.org/2704443002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2704443002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:473: if
(newRange->collapsed())
How about below?

builder.setBaseAndExtent(EphemeralRange(newRange))

[tkent, 2017-02-16 13:07:14]

Description was changed from

==========
Selection API: extend() should operate based on DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

to

==========
Selection API: extend() should operate DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

[tkent, 2017-02-16 13:21:47]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 13:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-16 14:42:25]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2017-02-16 14:44:26]

https://codereview.chromium.org/2704443002/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2704443002/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:473: if
(newRange->collapsed())
On 2017/02/16 at 10:05:41, yosin_UTC9 wrote:
> How about below?
> 
> builder.setBaseAndExtent(EphemeralRange(newRange))

It doesn't work in step 7 case.

[tkent, 2017-02-16 14:44:29]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-16 14:44:30]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2704443002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-16 14:44:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 14:55:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487256269960050,
"parent_rev": "5fdb85e384dd972552e22622350d12ff8492c686", "commit_rev":
"4d81e25a23b11c7193b09b3e2f4d69f3d06d31a6"}

[commit-bot: I haz the power, 2017-02-16 14:56:29]

Description was changed from

==========
Selection API: extend() should operate DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400
==========

to

==========
Selection API: extend() should operate DOM Ranges.

This CL fixes 1,856 tests in external/wpt/selection/.


BUG=692400

Review-Url: https://codereview.chromium.org/2704443002
Cr-Commit-Position: refs/heads/master@{#450962}
Committed:
https://chromium.googlesource.com/chromium/src/+/4d81e25a23b11c7193b09b3e2f4d...
==========

[commit-bot: I haz the power, 2017-02-16 14:56:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4d81e25a23b11c7193b09b3e2f4d...