third_party/WebKit/Source/core/editing/DOMSelection.h - Issue 2695193002: Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the spec…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.h

Issue 2695193002: Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the spec… (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/DOMSelection.h

diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.h b/third_party/WebKit/Source/core/editing/DOMSelection.h

index 9723ea4e4df7d0bf3a62e8d091f3463d1c64d6a8..b983c877129bb251bec1cfbc3770702d1b95b149 100644

--- a/third_party/WebKit/Source/core/editing/DOMSelection.h

+++ b/third_party/WebKit/Source/core/editing/DOMSelection.h

@@ -108,8 +108,9 @@ class CORE_EXPORT DOMSelection final : public GarbageCollected<DOMSelection>,

bool isAvailable() const;

- // Convenience method for accessors, does not check m_frame present.

+ // Convenience methods for accessors, does not check m_frame present.

const VisibleSelection& visibleSelection() const;

+ bool isBaseFirstInSelection() const;

Node* shadowAdjustedNode(const Position&) const;

int shadowAdjustedOffset(const Position&) const;