third_party/WebKit/LayoutTests/editing/selection/legal-positions.html - Issue 2695193002: Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the spec…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/legal-positions.html

Issue 2695193002: Selection API: setBaseAndExtent() and selectAllChildren() should create new Range based on the spec… (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/getRangeAt-expected.txt ('k') | third_party/WebKit/LayoutTests/editing/selection/select_all/select_all_html.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/legal-positions.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/legal-positions.html b/third_party/WebKit/LayoutTests/editing/selection/legal-positions.html

index 679f6ec57dbb548ee4727cf9810060bf095a713f..f87f80c4da3982787d610db856e7cc3492475876 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/legal-positions.html

+++ b/third_party/WebKit/LayoutTests/editing/selection/legal-positions.html

@@ -33,10 +33,10 @@ if (window.testRunner)

// The textnode

s.setBaseAndExtent(e, 0, e, 1);

r = s.getRangeAt(0);

-assert(r.startContainer == e.childNodes[0]);

+assert(r.startContainer == e);

assert(r.startOffset == 0);

-assert(r.endContainer == e.childNodes[0]);

-assert(r.endOffset == r.endContainer.length);

+assert(r.endContainer == e);

+assert(r.endOffset == 1);

// The image

s.setBaseAndExtent(e, 1, e, 2);