[InputEvent] Change |getTargetRanges()| to return current selection by default

[InputEvent] Change |getTargetRanges()| to return current selection by default

For ContentEditable |getTargetRanges()| should:
  1. Return corresponding ranges for delete-content/word/line.
  2. Return current selection for other types.

For <input> and <textarea> |getTargetRanges()| should return empty array. 

This CL matches Safari Technology Preview.

BUG=652429
Review-Url: https://codereview.chromium.org/2693863003
Cr-Commit-Position: refs/heads/master@{#450567}
Committed: https://chromium.googlesource.com/chromium/src/+/07359e3b41086b15af2bf433a28f1a4d8b31ff9b

[chongz, 2017-02-13 23:33:03]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 23:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-02-13 23:39:14]

Description was changed from

==========
Use current selection as default

BUG=
==========

to

==========
[InputEvent] Change |getTargetRanges()| to return current selection by default

For ContentEditable |getTargetRanges()| should:
  1. Return corresponding ranges for delete-content/word/line.
  2. Return current selection for other types.

For <input> and <textarea> |getTargetRanges()| should return empty array. 

This CL matches Safari Technology Preview.

BUG=652429
==========

[chongz, 2017-02-13 23:39:25]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-02-14 01:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:24:10]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-02-14 02:25:09]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-02-14 02:25:09]

yosin@ PTAL, thanks!

[yosin_UTC9, 2017-02-14 03:43:46]

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2045: const
RangeVector* targetRangesForInputEvent(Node* node) {
Could you use |const Node&|? |node| can not be nullptr.

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2714:
!hasRichlyEditableStyle(*eventTargetNodeForDocument(m_frame->document())))
Since |eventTargetNodeForDocument()| can return nullptr in ultimate situation,
but ClusterFuzz can introduce so.
Please check nullptr from  |eventTargetNodeForDocument()|

[chongz, 2017-02-14 15:36:37]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 15:37:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 16:54:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:54:22]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-02-14 18:57:51]

yosin@ PTAL again, thanks!

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:2045: const
RangeVector* targetRangesForInputEvent(Node* node) {
On 2017/02/14 03:43:45, yosin_UTC9 wrote:
> Could you use |const Node&|? |node| can not be nullptr.

Done.

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2693863003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:2714:
!hasRichlyEditableStyle(*eventTargetNodeForDocument(m_frame->document())))
On 2017/02/14 03:43:45, yosin_UTC9 wrote:
> Since |eventTargetNodeForDocument()| can return nullptr in ultimate situation,
> but ClusterFuzz can introduce so.
> Please check nullptr from  |eventTargetNodeForDocument()|

Done.

[yosin_UTC9, 2017-02-15 01:33:16]

lgtm

Thanks for quick work!

[yosin_UTC9, 2017-02-15 01:33:17]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-15 01:34:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 05:45:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487122397780840,
"parent_rev": "0b3c819b0e36250bf36c04e3d8e2dc9e26317238", "commit_rev":
"07359e3b41086b15af2bf433a28f1a4d8b31ff9b"}

[commit-bot: I haz the power, 2017-02-15 05:46:29]

Description was changed from

==========
[InputEvent] Change |getTargetRanges()| to return current selection by default

For ContentEditable |getTargetRanges()| should:
  1. Return corresponding ranges for delete-content/word/line.
  2. Return current selection for other types.

For <input> and <textarea> |getTargetRanges()| should return empty array. 

This CL matches Safari Technology Preview.

BUG=652429
==========

to

==========
[InputEvent] Change |getTargetRanges()| to return current selection by default

For ContentEditable |getTargetRanges()| should:
  1. Return corresponding ranges for delete-content/word/line.
  2. Return current selection for other types.

For <input> and <textarea> |getTargetRanges()| should return empty array. 

This CL matches Safari Technology Preview.

BUG=652429

Review-Url: https://codereview.chromium.org/2693863003
Cr-Commit-Position: refs/heads/master@{#450567}
Committed:
https://chromium.googlesource.com/chromium/src/+/07359e3b41086b15af2bf433a28f...
==========

[commit-bot: I haz the power, 2017-02-15 05:46:30]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/07359e3b41086b15af2bf433a28f...