third_party/WebKit/Source/core/editing/Editor.h - Issue 2693863003: [InputEvent] Change |getTargetRanges()| to return current selection by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 2693863003: [InputEvent] Change |getTargetRanges()| to return current selection by default (Closed)

Patch Set: yosin's review: Use const Node&, add null checks Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.h

diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h

index 09cf8e605d1d663865e9d4757418193ce9e422d7..dc3081d62617ab6848756488485f8a7624eb6a47 100644

--- a/third_party/WebKit/Source/core/editing/Editor.h

+++ b/third_party/WebKit/Source/core/editing/Editor.h

@@ -168,7 +168,7 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {

// Returns target ranges for the command, currently only supports delete

// related commands. Used by InputEvent.

- RangeVector* getTargetRanges() const;

+ const RangeVector* getTargetRanges() const;

const EditorInternalCommand* m_command;

EditorCommandSource m_source;