third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp - Issue 2693863003: [InputEvent] Change |getTargetRanges()| to return current selection by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

Issue 2693863003: [InputEvent] Change |getTargetRanges()| to return current selection by default (Closed)

Patch Set: yosin's review: Use const Node&, add null checks Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

index 275e8126b794cc034940d608e3cdb40f34203709..cfca437097a7b9dbf2570f197d4774406647c901 100644

--- a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

+++ b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

@@ -73,7 +73,7 @@ bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt) {

}

// Return true to prevent default action. e.g. Space key scroll.

- if (dispatchBeforeInputInsertText(evt->target(), keyEvent->text) !=

+ if (dispatchBeforeInputInsertText(evt->target()->toNode(), keyEvent->text) !=

DispatchEventResult::NotCanceled)

return true;