[InputEvent] Change |getTargetRanges()| to return current selection by default

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 2024 matching lines @@
   // otherwise, make sure to be at the start of the first selected node,
   // instead of possibly at the end of the last node before the selection
   return mostForwardCaretPosition(visiblePosition.deepEquivalent());
 }
 
 bool isTextSecurityNode(const Node* node) {
   return node && node->layoutObject() &&
          node->layoutObject()->style()->textSecurity() != TSNONE;
 }
 
-DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target,
+const RangeVector* targetRangesForInputEvent(Node* node) {

[yosin_UTC9, 2017/02/14 03:43:45]

Could you use |const Node&|? |node| can not be nullptr.

[chongz, 2017/02/14 18:57:51]

Done.

+  if (!hasRichlyEditableStyle(*node))
+    return nullptr;
+  return new RangeVector(
+      1, firstRangeOf(node->document().frame()->selection().selection()));
+}
+
+DispatchEventResult dispatchBeforeInputInsertText(Node* target,
                                                   const String& data) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
   // TODO(chongz): Pass appropriate |ranges| after it's defined on spec.
   // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
-  InputEvent* beforeInputEvent = InputEvent::createBeforeInput(
-      InputEvent::InputType::InsertText, data,
-      InputEvent::EventCancelable::IsCancelable,
-      InputEvent::EventIsComposing::NotComposing, nullptr);
+  InputEvent* beforeInputEvent =
+      InputEvent::createBeforeInput(InputEvent::InputType::InsertText, data,
+                                    InputEvent::EventCancelable::IsCancelable,
+                                    InputEvent::EventIsComposing::NotComposing,
+                                    targetRangesForInputEvent(target));
   return target->dispatchEvent(beforeInputEvent);
 }
 
 DispatchEventResult dispatchBeforeInputEditorCommand(
-    EventTarget* target,
+    Node* target,
     InputEvent::InputType inputType,
     const RangeVector* ranges) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
   InputEvent* beforeInputEvent = InputEvent::createBeforeInput(
       inputType, nullAtom, InputEvent::EventCancelable::IsCancelable,
       InputEvent::EventIsComposing::NotComposing, ranges);
   return target->dispatchEvent(beforeInputEvent);
 }
 
 DispatchEventResult dispatchBeforeInputDataTransfer(
-    EventTarget* target,
+    Node* target,
     InputEvent::InputType inputType,
-    DataTransfer* dataTransfer,
-    const RangeVector* ranges) {
+    DataTransfer* dataTransfer) {
   if (!RuntimeEnabledFeatures::inputEventEnabled())
     return DispatchEventResult::NotCanceled;
   if (!target)
     return DispatchEventResult::NotCanceled;
 
   DCHECK(inputType == InputEvent::InputType::InsertFromPaste ||
          inputType == InputEvent::InputType::InsertReplacementText ||
          inputType == InputEvent::InputType::InsertFromDrop ||
          inputType == InputEvent::InputType::DeleteByCut)
       << "Unsupported inputType: " << (int)inputType;
 
   InputEvent* beforeInputEvent;
 
   if (hasRichlyEditableStyle(*(target->toNode())) || !dataTransfer) {
     beforeInputEvent = InputEvent::createBeforeInput(
         inputType, dataTransfer, InputEvent::EventCancelable::IsCancelable,
-        InputEvent::EventIsComposing::NotComposing, ranges);
+        InputEvent::EventIsComposing::NotComposing,
+        targetRangesForInputEvent(target));
   } else {
     const String& data = dataTransfer->getData(mimeTypeTextPlain);
     // TODO(chongz): Pass appropriate |ranges| after it's defined on spec.
     // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
     beforeInputEvent = InputEvent::createBeforeInput(
         inputType, data, InputEvent::EventCancelable::IsCancelable,
-        InputEvent::EventIsComposing::NotComposing, nullptr);
+        InputEvent::EventIsComposing::NotComposing,
+        targetRangesForInputEvent(target));
   }
   return target->dispatchEvent(beforeInputEvent);
 }
 
 InputEvent::InputType deletionInputTypeFromTextGranularity(
     DeleteDirection direction,
     TextGranularity granularity) {
   using InputType = InputEvent::InputType;
   switch (direction) {
     case DeleteDirection::Forward:
       if (granularity == WordGranularity)
         return InputType::DeleteWordForward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineForward;
       return InputType::DeleteContentForward;
     case DeleteDirection::Backward:
       if (granularity == WordGranularity)
         return InputType::DeleteWordBackward;
       if (granularity == LineBoundary)
         return InputType::DeleteLineBackward;
       return InputType::DeleteContentBackward;
     default:
       return InputType::None;
   }
 }
 
 }  // namespace blink