Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError.

Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

* fast/forms/file/file-crash-by-runin-parent.html
This CL removes the test because the test is obsolete. We removed display:run-in
several years ago.

BUG=691422
Review-Url: https://codereview.chromium.org/2693813002
Cr-Commit-Position: refs/heads/master@{#450006}
Committed: https://chromium.googlesource.com/chromium/src/+/66f70447e561ce2d850be2e2ef4d1a1be4364ac7

[tkent, 2017-02-13 05:17:16]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 05:17:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 07:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 07:03:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-02-13 07:53:29]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 07:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-13 07:57:41]

Description was changed from

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

BUG=691422
==========

to

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

This CL fixes 589 sub-tests in external/wpt/selection/.

BUG=691422
==========

[tkent, 2017-02-13 07:59:39]

Description was changed from

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

This CL fixes 589 sub-tests in external/wpt/selection/.

BUG=691422
==========

to

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

BUG=691422
==========

[tkent, 2017-02-13 09:11:01]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 09:11:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-13 09:11:54]

Description was changed from

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

BUG=691422
==========

to

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

* fast/forms/file/file-crash-by-runin-parent.html
This CL removes the test because the test is obsolete. We removed display:run-in
several years ago.

BUG=691422
==========

[tkent, 2017-02-13 09:12:23]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-13 09:12:29]

Patchset #1 (id:20001) has been deleted

[tkent, 2017-02-13 09:13:41]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-13 09:13:42]

yoichio@, yosin@, would you review this please?

[yosin_UTC9, 2017-02-13 09:55:24]

lgtm

What a wonderful patch is!
Thanks for working this!
(^_^)b

[yosin_UTC9, 2017-02-13 09:55:28]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-13 09:55:31]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-13 09:55:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-13 10:38:55]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2017-02-13 16:27:55]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 16:28:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:50:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:50:05]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-13 17:58:56]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-13 17:58:57]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2693813002/#ps60001
(title: "adjust 2 more tests")

[commit-bot: I haz the power, 2017-02-13 17:59:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 18:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487008736726550,
"parent_rev": "f212cc56820dda5e8b5d902a15e39bcb09c37df5", "commit_rev":
"66f70447e561ce2d850be2e2ef4d1a1be4364ac7"}

[commit-bot: I haz the power, 2017-02-13 18:06:36]

Description was changed from

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

* fast/forms/file/file-crash-by-runin-parent.html
This CL removes the test because the test is obsolete. We removed display:run-in
several years ago.

BUG=691422
==========

to

==========
Selection API: Some functions should throw InvalidNodeTypeError and
IndexSizeError.

* setBaseAndExtent() should throw InvalidNodeTypeError for DOCTYPEs.

* setBaseAndExtent() should throw IndexSizeError for too large offsets.

* extend() should InvalidNodeTyepError for DOCTYPEs.

* collapse() should call checkNodeWOffset() earlier than isValidForPosition()
  https://www.w3.org/TR/selection-api/#dom-selection-collapse
  checkNodeWOffset() is for step 2, isValidForPosition() is for step 3.

New behavior matches to Edge, Firefox, and Selection API standard.
This CL fixes 589 sub-tests in external/wpt/selection/.

* fast/forms/file/file-crash-by-runin-parent.html
This CL removes the test because the test is obsolete. We removed display:run-in
several years ago.

BUG=691422

Review-Url: https://codereview.chromium.org/2693813002
Cr-Commit-Position: refs/heads/master@{#450006}
Committed:
https://chromium.googlesource.com/chromium/src/+/66f70447e561ce2d850be2e2ef4d...
==========

[commit-bot: I haz the power, 2017-02-13 18:06:37]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/66f70447e561ce2d850be2e2ef4d...