third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html - Issue 2693813002: Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html

Issue 2693813002: Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError. (Closed)

Patch Set: adjust 2 more tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html ('k') | third_party/WebKit/LayoutTests/fast/forms/file/file-crash-by-runin-parent.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html b/third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html

index 45ae70df157ea73019a2b13b6a770bb29c74cde6..c2ee3c480d9a6373cb6bd2fad3571de5f87c7c95 100644

--- a/third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/dynamic/checkbox-selection-crash.html

@@ -16,7 +16,7 @@ Loading this page should not crash.

var sel = window.getSelection();

var td1 = document.getElementById('td1')

// having selection triggers Document::updateRendering() from paint()

- sel.setBaseAndExtent(td1, 0, td1, 1000);

+ sel.setBaseAndExtent(td1, 0, td1, 3);

// this causes style recalc and rendering tree tear down (from updateRendering) in middle of painting, which crashes

document.body.setAttribute('class','gone');

var cb = document.getElementById('cb')