Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError.

third_party/WebKit/Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 179 matching lines @@
     UseCounter::count(frame(), UseCounter::SelectionCollapseNull);
     frame()->selection().clear();
     return;
   }
 
   if (offset < 0) {
     exceptionState.throwDOMException(
         IndexSizeError, String::number(offset) + " is not a valid offset.");
     return;
   }
+  Range::checkNodeWOffset(node, offset, exceptionState);
+  if (exceptionState.hadException())
+    return;
 
   if (!isValidForPosition(node))
     return;
-  Range::checkNodeWOffset(node, offset, exceptionState);
-  if (exceptionState.hadException())
-    return;
 
   frame()->selection().setSelection(
       SelectionInDOMTree::Builder()
           .collapse(Position(node, offset))
           .setIsDirectional(frame()->selection().isDirectional())
           .build());
 }
 
 void DOMSelection::collapseToEnd(ExceptionState& exceptionState) {
   if (!isAvailable())
@@ skipping 62 matching lines @@
   if (!baseNode) {
     UseCounter::count(frame(), UseCounter::SelectionSetBaseAndExtentNull);
     frame()->selection().clear();
     return;
   }
   if (!extentNode) {
     UseCounter::count(frame(), UseCounter::SelectionSetBaseAndExtentNull);
     extentOffset = 0;
   }
 
+  Range::checkNodeWOffset(baseNode, baseOffset, exceptionState);
+  if (exceptionState.hadException())
+    return;
+  if (extentNode) {
+    Range::checkNodeWOffset(extentNode, extentOffset, exceptionState);
+    if (exceptionState.hadException())
+      return;
+  }
+
   if (!isValidForPosition(baseNode) || !isValidForPosition(extentNode))
     return;
 
   clearCachedRangeIfSelectionOfDocument();
 
   // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   // In the long term, we should change FrameSelection::setSelection to take a
   // parameter that does not require clean layout, so that modifying selection
   // no longer performs synchronous layout by itself.
@@ skipping 75 matching lines @@
     exceptionState.throwDOMException(
         InvalidStateError, "This Selection object doesn't have any Ranges.");
     return;
   }
 
   if (offset < 0) {
     exceptionState.throwDOMException(
         IndexSizeError, String::number(offset) + " is not a valid offset.");
     return;
   }
-  if (static_cast<unsigned>(offset) > node->lengthOfContents()) {
-    exceptionState.throwDOMException(
-        IndexSizeError,
-        String::number(offset) + " is larger than the given node's length.");
+  Range::checkNodeWOffset(node, offset, exceptionState);
+  if (exceptionState.hadException())
     return;
-  }
 
   if (!isValidForPosition(node))
     return;
 
   clearCachedRangeIfSelectionOfDocument();
   const Position& base = frame()->selection().base();
   if (base.isNull()) {
     // TODO(editing-dev): We should throw |InvalidStateError| if selection is
     // none to follow the spec.
     frame()->selection().setSelection(SelectionInDOMTree::Builder()
@@ skipping 310 matching lines @@
     m_treeScope->document().addConsoleMessage(
         ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection) {
   visitor->trace(m_treeScope);
   ContextClient::trace(visitor);
 }
 
 }  // namespace blink