third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js - Issue 2693813002: Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2693813002: Selection API: Some functions should throw InvalidNodeTypeError and IndexSizeError. (Closed)

Patch Set: adjust 2 more tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

index 9325f062ba194ca295ac7da8407b8918ee9017d0..2a612ed08955cba93de5690ba0a6c511fc4dcb9c 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

@@ -2369,7 +2369,8 @@ Elements.StylePropertyTreeElement = class extends UI.TreeElement {

if (isEditingName)

proxyElement.addEventListener('paste', pasteHandler.bind(this, context), false);

- selectElement.getComponentSelection().setBaseAndExtent(selectElement, 0, selectElement, 1);

+ selectElement.getComponentSelection().setBaseAndExtent(

+ selectElement, 0, selectElement, selectElement.firstChild ? 1 : 0);

}

/**

« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »