Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: net/tools/quic/quic_simple_server_session_test.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: Spin the message loop to ensure the client receives the response Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_simple_dispatcher.cc ('k') | net/tools/quic/test_tools/mock_quic_session_visitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_simple_server_session_test.cc
diff --git a/net/tools/quic/quic_simple_server_session_test.cc b/net/tools/quic/quic_simple_server_session_test.cc
index 2d90c26b7a168009c239f940b98688d3d16e84fc..4cc03290a4f10a440e0ba43027ac1868ac5622aa 100644
--- a/net/tools/quic/quic_simple_server_session_test.cc
+++ b/net/tools/quic/quic_simple_server_session_test.cc
@@ -236,6 +236,7 @@ TEST_P(QuicSimpleServerSessionTest, CloseStreamDueToReset) {
// Receive a reset (and send a RST in response).
QuicRstStreamFrame rst1(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM,
0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst1);
@@ -253,6 +254,7 @@ TEST_P(QuicSimpleServerSessionTest, NeverOpenStreamDueToReset) {
// Send a reset (and expect the peer to send a RST in response).
QuicRstStreamFrame rst1(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM,
0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst1);
@@ -279,6 +281,7 @@ TEST_P(QuicSimpleServerSessionTest, AcceptClosedStream) {
// Send a reset (and expect the peer to send a RST in response).
QuicRstStreamFrame rst(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM, 0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst);
@@ -570,6 +573,7 @@ TEST_P(QuicSimpleServerSessionServerPushTest,
// Reset the last stream in the queue. It should be marked cancelled.
QuicStreamId stream_got_reset = num_resources * 2;
QuicRstStreamFrame rst(stream_got_reset, QUIC_STREAM_CANCELLED, 0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(stream_got_reset, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst);
@@ -614,6 +618,7 @@ TEST_P(QuicSimpleServerSessionServerPushTest,
.WillOnce(Return(QuicConsumedData(kStreamFlowControlWindowSize, false)));
EXPECT_CALL(*connection_, SendBlocked(stream_to_open));
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
QuicRstStreamFrame rst(stream_got_reset, QUIC_STREAM_CANCELLED, 0);
visitor_->OnRstStream(rst);
}
« no previous file with comments | « net/tools/quic/quic_simple_dispatcher.cc ('k') | net/tools/quic/test_tools/mock_quic_session_visitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698