Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: Spin the message loop to ensure the client receives the response Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index 00ab3d3c34fe62eb727699997e70853968fbd52e..4f20674202d1c5218e27bbda11ab3a7702b0dce8 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -332,6 +332,13 @@ net::QuicVersion GetQuicVersion(const VariationParameters& quic_trial_params) {
GetVariationParam(quic_trial_params, "quic_version"));
}
+bool ShouldEnableServerPushCancelation(
+ const VariationParameters& quic_trial_params) {
+ return base::LowerCaseEqualsASCII(
+ GetVariationParam(quic_trial_params, "enable_server_push_cancellation"),
+ "true");
+}
+
void ConfigureQuicParams(base::StringPiece quic_trial_group,
const VariationParameters& quic_trial_params,
bool is_quic_force_disabled,
@@ -343,6 +350,10 @@ void ConfigureQuicParams(base::StringPiece quic_trial_group,
is_quic_force_enabled);
params->mark_quic_broken_when_network_blackholes =
ShouldMarkQuicBrokenWhenNetworkBlackholes(quic_trial_params);
+
+ params->enable_server_push_cancellation =
+ ShouldEnableServerPushCancelation(quic_trial_params);
+
params->retry_without_alt_svc_on_quic_errors =
ShouldRetryWithoutAltSvcOnQuicErrors(quic_trial_params);
params->enable_quic_alternative_service_with_different_host =
« no previous file with comments | « no previous file | components/network_session_configurator/network_session_configurator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698