Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: Spin the message loop to ensure the client receives the response Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index 799f9ca4023caed782d5d699aa12b49b2186f45e..aa9e4c614ff7f5159496c394d894de0362cfd391 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -75,6 +75,7 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_disable_connection_pooling);
EXPECT_EQ(0.25f, params_.quic_load_server_info_timeout_srtt_multiplier);
EXPECT_FALSE(params_.quic_enable_connection_racing);
+ EXPECT_FALSE(params_.enable_server_push_cancellation);
EXPECT_FALSE(params_.quic_enable_non_blocking_io);
EXPECT_FALSE(params_.quic_disable_disk_cache);
EXPECT_FALSE(params_.quic_prefer_aes);
@@ -222,6 +223,17 @@ TEST_F(NetworkSessionConfiguratorTest, QuicRaceCertVerification) {
EXPECT_TRUE(params_.quic_race_cert_verification);
}
+TEST_F(NetworkSessionConfiguratorTest, EnableServerPushCancellation) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["enable_server_push_cancellation"] = "true";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_TRUE(params_.enable_server_push_cancellation);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicDoNotFragment) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["do_not_fragment"] = "true";
« no previous file with comments | « components/network_session_configurator/network_session_configurator.cc ('k') | net/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698