Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2692343006: [Bindings] Declare signature and executionContext once (Closed)

Created:
3 years, 10 months ago by peria
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Declare signature and executionContext once in a method preparePrototypeAndInterfaceObject(). If we want to install conditional attributes and methods in a (partial) interface, we declared them independently and had compile errors. Plus, in the details, two macros created executionContext from literally different v8::Context's, but they are actually same in the call sites. Hence we need one signature and one executionContext. BUG=690714 Review-Url: https://codereview.chromium.org/2692343006 Cr-Commit-Position: refs/heads/master@{#450960} Committed: https://chromium.googlesource.com/chromium/src/+/2df25dd0beaa6ff0750ad1bae330e3d9ff84a9c0

Patch Set 1 #

Patch Set 2 : Add a test #

Messages

Total messages: 15 (10 generated)
peria
PTL
3 years, 10 months ago (2017-02-16 09:20:58 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-16 09:22:04 UTC) #4
Yuki
LGTM.
3 years, 10 months ago (2017-02-16 10:21:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692343006/20001
3 years, 10 months ago (2017-02-16 10:39:54 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 14:45:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2df25dd0beaa6ff0750ad1bae330...

Powered by Google App Engine
This is Rietveld 408576698