Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

Issue 2692343006: [Bindings] Declare signature and executionContext once (Closed)
Patch Set: Add a test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_t o_local_cpp_value %} 1 {% from 'utilities.cpp.tmpl' import declare_enum_validation_variable, v8_value_t o_local_cpp_value %}
2 2
3 {##############################################################################} 3 {##############################################################################}
4 {% macro generate_method(method, world_suffix) %} 4 {% macro generate_method(method, world_suffix) %}
5 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info) { 5 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info) {
6 {% filter format_remove_duplicates([ 6 {% filter format_remove_duplicates([
7 'ExceptionState exceptionState', 7 'ExceptionState exceptionState',
8 'ScriptState* scriptState = ']) %} 8 'ScriptState* scriptState = ']) %}
9 {% set define_exception_state -%} 9 {% set define_exception_state -%}
10 ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionCont ext, "{{interface_name}}", "{{method.name}}"); 10 ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionCont ext, "{{interface_name}}", "{{method.name}}");
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 {######################################} 636 {######################################}
637 {% macro install_custom_signature(method, instance_template, prototype_template, interface_template, signature) %} 637 {% macro install_custom_signature(method, instance_template, prototype_template, interface_template, signature) %}
638 const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfiguration = {{method_configuration(method)}}; 638 const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfiguration = {{method_configuration(method)}};
639 V8DOMConfiguration::installMethod(isolate, world, {{instance_template}}, {{proto type_template}}, {{interface_template}}, {{signature}}, {{method.name}}MethodCon figuration); 639 V8DOMConfiguration::installMethod(isolate, world, {{instance_template}}, {{proto type_template}}, {{interface_template}}, {{signature}}, {{method.name}}MethodCon figuration);
640 {%- endmacro %} 640 {%- endmacro %}
641 641
642 642
643 {######################################} 643 {######################################}
644 {% macro install_conditionally_enabled_methods() %} 644 {% macro install_conditionally_enabled_methods() %}
645 {% if methods | conditionally_exposed(is_partial) %} 645 {% if methods | conditionally_exposed(is_partial) %}
646 {# Define operations with limited exposure #}
647 v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTempla te);
648 ExecutionContext* executionContext = toExecutionContext(prototypeObject->Creatio nContext());
649 DCHECK(executionContext);
650 {% for method in methods | conditionally_exposed(is_partial) %} 646 {% for method in methods | conditionally_exposed(is_partial) %}
651 {% filter secure_context(method.overloads.secure_context_test_all 647 {% filter secure_context(method.overloads.secure_context_test_all
652 if method.overloads else 648 if method.overloads else
653 method.secure_context_test) %} 649 method.secure_context_test) %}
654 {% filter exposed(method.overloads.exposed_test_all 650 {% filter exposed(method.overloads.exposed_test_all
655 if method.overloads else 651 if method.overloads else
656 method.exposed_test) %} 652 method.exposed_test) %}
657 {% filter runtime_enabled(method.overloads.runtime_enabled_all 653 {% filter runtime_enabled(method.overloads.runtime_enabled_all
658 if method.overloads else 654 if method.overloads else
659 method.runtime_enabled_feature_name) %} 655 method.runtime_enabled_feature_name) %}
660 const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfiguration = {{method_configuration(method)}}; 656 const V8DOMConfiguration::MethodConfiguration {{method.name}}MethodConfiguration = {{method_configuration(method)}};
661 V8DOMConfiguration::installMethod(isolate, world, v8::Local<v8::Object>(), proto typeObject, interfaceObject, signature, {{method.name}}MethodConfiguration); 657 V8DOMConfiguration::installMethod(isolate, world, v8::Local<v8::Object>(), proto typeObject, interfaceObject, signature, {{method.name}}MethodConfiguration);
662 {% endfilter %}{# runtime_enabled() #} 658 {% endfilter %}{# runtime_enabled() #}
663 {% endfilter %}{# exposed() #} 659 {% endfilter %}{# exposed() #}
664 {% endfilter %}{# secure_context() #} 660 {% endfilter %}{# secure_context() #}
665 {% endfor %} 661 {% endfor %}
666 {% endif %} 662 {% endif %}
667 {%- endmacro %} 663 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698