third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2692343006: [Bindings] Declare signature and executionContext once

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2692343006: [Bindings] Declare signature and executionContext once (Closed)

Patch Set: Add a test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index 57ab4ac3dc3096a1afac1f3e30ef961dda890305..439615c4fd15d94c5bc8da58f2282b87ca9c18db 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -714,7 +714,13 @@ void {{v8_class_or_partial}}::preparePrototypeAndInterfaceObject(v8::Local<v8::C

{% if is_partial %}

{{v8_class}}::preparePrototypeAndInterfaceObject(context, world, prototypeObject, interfaceObject, interfaceTemplate);

{% endif %}

v8::Isolate* isolate = context->GetIsolate();

+ {% if has_conditional_attributes_on_prototype or methods | conditionally_exposed(is_partial) %}

+ v8::Local<v8::Signature> signature = v8::Signature::New(isolate, interfaceTemplate);

+ ExecutionContext* executionContext = toExecutionContext(context);

+ DCHECK(executionContext);

+ {% endif %}

{% if unscopables %}

v8::Local<v8::Name> unscopablesSymbol(v8::Symbol::GetUnscopables(isolate));