[Bindings] Unify a template block 'prepare_prototype_and_interface_object'

Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move it to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
Review-Url: https://codereview.chromium.org/2692343005
Cr-Commit-Position: refs/heads/master@{#450918}
Committed: https://chromium.googlesource.com/chromium/src/+/1397281ab2c5d5e47437363822b7439196851ea3

[peria, 2017-02-16 08:07:18]

Description was changed from

==========
Unify prepare_ block

BUG=690714
==========

to

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to load another
preparePrototypeAndInterfaceObject method of parent class.

Hence this CL merges them and move to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

[peria, 2017-02-16 08:08:07]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[peria, 2017-02-16 08:08:30]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-02-16 08:08:30]

PTL

[commit-bot: I haz the power, 2017-02-16 08:09:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-02-16 08:12:31]

LGTM

[peria, 2017-02-16 08:15:50]

Description was changed from

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to load another
preparePrototypeAndInterfaceObject method of parent class.

Hence this CL merges them and move to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

to

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

[peria, 2017-02-16 08:16:05]

Description was changed from

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

to

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move it to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

[bashi, 2017-02-16 08:20:18]

Just help me understand: This CL itself doesn't fix the bug, but is a
preparation for the actual fix. A following CL will add a filter that removes
duplicate variable declaration. Is my understanding correct?

[peria, 2017-02-16 08:22:58]

On 2017/02/16 08:20:18, bashi wrote:
> Just help me understand: This CL itself doesn't fix the bug, but is a
> preparation for the actual fix. A following CL will add a filter that removes
> duplicate variable declaration. Is my understanding correct?

Yes, you're correct.
This is just a refactoring CL, but I think it better to land this first
to simplify the practical change.

[bashi, 2017-02-16 08:24:14]

Totally makes sense to me. lgtm.

[Yuki, 2017-02-16 08:38:08]

LGTM.

https://codereview.chromium.org/2692343005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
(right):

https://codereview.chromium.org/2692343005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl:709: {%
block prepare_prototype_and_interface_object %}
nit: This is just fine as is, but technically you no longer need {% block %}
because you don't expand this block somewhere else.

[peria, 2017-02-16 08:41:42]

The CQ bit was unchecked by peria@chromium.org

[peria, 2017-02-16 08:41:43]

The CQ bit was checked by peria@chromium.org

[peria, 2017-02-16 08:41:58]

https://codereview.chromium.org/2692343005/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
(right):

https://codereview.chromium.org/2692343005/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl:709: {%
block prepare_prototype_and_interface_object %}
On 2017/02/16 08:38:07, Yuki wrote:
> nit: This is just fine as is, but technically you no longer need {% block %}
> because you don't expand this block somewhere else.

Acknowledged.

[commit-bot: I haz the power, 2017-02-16 08:42:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 09:48:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487234503156620, "parent_rev":
"704e5153f057ce179dc44ff6b4f6a0d565d886e4", "commit_rev":
"1397281ab2c5d5e47437363822b7439196851ea3"}

[commit-bot: I haz the power, 2017-02-16 09:48:52]

Description was changed from

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move it to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714
==========

to

==========
Unify a template block 'prepare_prototype_and_interface_object'

This block was defined in interface.cpp.tmpl and partial_interface.cpp.tmpl,
but the difference between them is only to call another
preparePrototypeAndInterfaceObject() of parent class.

Hence this CL merges them and move it to interface_base.cpp.tmpl.
As a side effect, a macro is expanded and another macro is
moved to attributes.cpp.tmpl.


BUG=690714

Review-Url: https://codereview.chromium.org/2692343005
Cr-Commit-Position: refs/heads/master@{#450918}
Committed:
https://chromium.googlesource.com/chromium/src/+/1397281ab2c5d5e47437363822b7...
==========

[commit-bot: I haz the power, 2017-02-16 09:48:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1397281ab2c5d5e47437363822b7...