Improve compile-time error handling.

Improve compile-time error handling.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/77ba539a72fb068d9c1aa33df9db030308bd805f

[ahe, 2017-02-10 17:27:44]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[ahe, 2017-02-10 19:37:48]

Note: I uploaded a new patch set with updated expectations.

[Siggi Cherem (dart-lang), 2017-02-10 23:12:32]

lgtm - minor name suggestion below

https://codereview.chromium.org/2691613002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/errors.dart (right):

https://codereview.chromium.org/2691613002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/errors.dart:57: dynamic inputError(Uri uri, int
charOffset, Object error) {
As error-recovery matures is the idea that if we have an input that produces an
input error, we'll work to make it into a recoverable compile-time error and get
rid of the input error?

If so, maybe call this unexpectedInputError to highlight that this should be
used only as a marker that something unexpected happened?

[ahe, 2017-02-13 14:41:03]

Thank you, Siggi!

https://codereview.chromium.org/2691613002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/errors.dart (right):

https://codereview.chromium.org/2691613002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/errors.dart:57: dynamic inputError(Uri uri, int
charOffset, Object error) {
On 2017/02/10 23:12:32, Siggi Cherem (dart-lang) wrote:
> As error-recovery matures is the idea that if we have an input that produces
an
> input error, we'll work to make it into a recoverable compile-time error and
get
> rid of the input error?
> 
> If so, maybe call this unexpectedInputError to highlight that this should be
> used only as a marker that something unexpected happened?

There are times when this is the correct method to use, for example, when
reporting an error on a command line option.

I do like the name "unexpectedInput" as this completely removes the word "error"
from the stack trace.

I'll rename this in a future CL.

[ahe, 2017-02-13 14:45:35]

Description was changed from

==========
Improve compile-time error handling.
==========

to

==========
Improve compile-time error handling.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/77ba539a72fb068d9c1aa33df9db030308bd805f
==========

[ahe, 2017-02-13 14:45:36]

Committed patchset #3 (id:40001) manually as
77ba539a72fb068d9c1aa33df9db030308bd805f (presubmit successful).